From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv3 2/3] gdb/testsuite: Detect and warn about duplicate test names
Date: Mon, 3 Aug 2020 11:02:15 +0100 [thread overview]
Message-ID: <20200803100215.GT853475@embecosm.com> (raw)
In-Reply-To: <685b3981-8a03-ff1b-ce22-a7fd101c6fef@simark.ca>
* Simon Marchi <simark@simark.ca> [2020-07-31 17:34:06 -0400]:
> On 2020-04-30 7:20 a.m., Andrew Burgess wrote:
> > Building on the previous commit, this patch detects when two tests
> > have the same test name and causes Dejagnu to print a new result type
> > '# of duplicate test names' in the result summary. A line starting
> > with 'DUPLICATE: ' is also added to the gdb.sum and gdb.log files.
> >
> > The DUPLICATE markers will be printed the second time a duplicate test
> > name is seen, and every time after that. So you might see:
> >
> > PASS: gdb.base/sometest.exp: foo
> > PASS: gdb.base/sometest.exp: bar
> > PASS: gdb.base/sometest.exp: foo
> > DUPLICATE: gdb.base/sometest.exp: foo
> > PASS: gdb.base/sometest.exp: baz
> > PASS: gdb.base/sometest.exp: foo
> > DUPLICATE: gdb.base/sometest.exp: foo
> >
> > However, the results will report a duplicate count of 1, indicating
> > that just one test name (foo) was duplicated.
> >
> > Currently if the tests are run in parallel mode the new result type is
> > not merged into the combined summary file so users will need to run in
> > non-parallel mode to check this result. Similarly, the 'DUPLICATE: '
> > markers will not be merged into the final gdb.sum file. A later
> > commit will fix this.
>
> Hi Andrew,
>
> When testing on Red Hat 7.8 (machine gcc135), I get this, which I think is related to this
> change.
>
> Running /home/simark/src/binutils-gdb/gdb/testsuite/gdb.ada/O2_float_param.exp ...
> can't unset "all_test_names": no such variable
> while executing
> "unset all_test_names"
>
> This machine has Dejagnu 1.5.1, which I suppose is the version that comes with this distro
> version.
`all_test_names` is local to gdb/testsuite/lib/check-test-names.exp,
so shouldn't depend on the version of dejagnu being run.
I tried installing version 1.5.1 of dejagnu, and as expected that
works fine.
My guess is that this is either a problem with an older version of
tcl, or maybe expect (?)
Or else, there's something specific about exactly what test you're
running, with the particular settings you're using that's triggering
this issue.
Can you include the output of `runtest --version` so we can see which
tcl/expect are being used, and provide the full `make check` command
you're running.
Thanks,
Andrew
next prev parent reply other threads:[~2020-08-03 10:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 17:53 [PATCH 0/4] Automatic detection of test name problems Andrew Burgess
2020-04-23 17:53 ` [PATCH 1/4] gdb/testsuite: Remove build paths from test names Andrew Burgess
2020-04-24 14:00 ` Simon Marchi
2020-04-23 17:53 ` [PATCH 2/4] gdb/testsuite: Detect and warn if paths are used in " Andrew Burgess
2020-04-23 20:26 ` Keith Seitz
2020-04-27 15:58 ` Andrew Burgess
2020-04-27 16:42 ` Keith Seitz
2020-04-27 19:06 ` Andrew Burgess
2020-04-23 17:53 ` [PATCH 3/4] gdb/testsuite: Detect and warn about duplicate " Andrew Burgess
2020-04-23 20:28 ` Keith Seitz
2020-04-23 17:53 ` [PATCH 4/4] contrib: Handle GDB specific test result types Andrew Burgess
2020-04-23 20:25 ` [PATCH 0/4] Automatic detection of test name problems Keith Seitz
2020-04-27 22:01 ` [PATCHv2 0/3] " Andrew Burgess
2020-04-27 22:01 ` [PATCHv2 1/3] gdb/testsuite: Detect and warn if paths are used in test names Andrew Burgess
2020-04-27 22:01 ` [PATCHv2 2/3] gdb/testsuite: Detect and warn about duplicate " Andrew Burgess
2020-04-27 22:01 ` [PATCHv2 3/3] contrib: Handle GDB specific test result types Andrew Burgess
2020-04-28 19:08 ` [PATCHv2 0/3] Automatic detection of test name problems Keith Seitz
2020-04-29 9:02 ` Andrew Burgess
2020-04-29 15:04 ` Simon Marchi
2020-04-29 15:38 ` Andrew Burgess
2020-04-29 16:03 ` Keith Seitz
2020-04-29 18:22 ` Simon Marchi
2020-04-30 11:20 ` [PATCHv3 " Andrew Burgess
2020-04-30 11:20 ` [PATCHv3 1/3] gdb/testsuite: Detect and warn if paths are used in test names Andrew Burgess
2020-04-30 11:20 ` [PATCHv3 2/3] gdb/testsuite: Detect and warn about duplicate " Andrew Burgess
2020-07-31 21:34 ` Simon Marchi
2020-08-03 10:02 ` Andrew Burgess [this message]
2020-08-03 12:18 ` Simon Marchi
2020-04-30 11:20 ` [PATCHv3 3/3] contrib: Handle GDB specific test result types Andrew Burgess
2020-04-30 18:01 ` [PATCHv3 0/3] Automatic detection of test name problems Tom Tromey
2020-05-11 21:30 ` Andrew Burgess
2020-05-12 16:48 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803100215.GT853475@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).