From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 4D9D83858D35 for ; Mon, 3 Aug 2020 10:02:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4D9D83858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x42d.google.com with SMTP id r2so28534612wrs.8 for ; Mon, 03 Aug 2020 03:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1tp5CWs/N7SeHCXEanR/YALy78DCqf/b/3nzBtlK0fA=; b=LJnBt9x0LjaYVAYiJ856V6ofLbDbwmnfaIfXKpmpeVmAeUH65RK1mVzTfzH0Eu9tvh GI6Ap80rjd1bOhp8bjkKHh7HLPrnLX/2xU4JHAbidegDjXSX/baacTJ/hu287dujM0g0 fhIFqPh2c0fHUepXrn0Unsl09bpXd0u6YbwbXXwGQmCM8aTe4ItYhO/QIeWQG/cJxokI hUorxtE9GA9kPthlyjeQvNN8SIjMue6rwN//fbtFJP2JiOdYYrgMoWXSMO82hzISXltl lWoZBHfb6psc7J8CfPjFXa87GMFBZ4PBajmJ6PlNBt136Wbd+2JlzpL16AG6DCV/jFqt Um9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1tp5CWs/N7SeHCXEanR/YALy78DCqf/b/3nzBtlK0fA=; b=iZ4zy5kTGoGKmFHEWjTKqyJLe/eGNZ4FPlPFhPFz0+uX90G4CT8eSfO44/XDSgjKRh OW0YIQJLZECyMC/ADjctEK+HZZcxpsXtYhccHhY9c2tKy1aNTg6mdbP7hh95lx2zKpLU SP6he7JNRNr+uMBY2YBQMyYBig7OA6is4STa/K1DL9JbpQ2EtCBQxxV5zX11IUJqhnVP a7hmttaUjO/+95aXffb5aMeF71I36jDIJCwTXvcRQaZ8RbY9mEWdm1DTbegp6/e8sFCK gII56izk+IaROdrOQ0vgVp9bDOV+g//dQWjm/qZMSNbzE1Lt5fAQQgqxCGmaGNjM330V m8hw== X-Gm-Message-State: AOAM532lvtzlw1zBmVpz8d6HZ9N4A/iMGa6t2wl2hivtZZyCFfNhKWQF oUzyTXYpLTq8B/iTTFYUQfY19TDTKmY= X-Google-Smtp-Source: ABdhPJxYMJvP5h8LA7kq18gCdaCrULUi4cegpcVEatAV8zB7PxlkxNJfgRZLCQakFsCKdWHiVakk1g== X-Received: by 2002:a5d:6910:: with SMTP id t16mr15363631wru.178.1596448937081; Mon, 03 Aug 2020 03:02:17 -0700 (PDT) Received: from localhost (host86-140-161-74.range86-140.btcentralplus.com. [86.140.161.74]) by smtp.gmail.com with ESMTPSA id z11sm22824874wrw.93.2020.08.03.03.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2020 03:02:16 -0700 (PDT) Date: Mon, 3 Aug 2020 11:02:15 +0100 From: Andrew Burgess To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv3 2/3] gdb/testsuite: Detect and warn about duplicate test names Message-ID: <20200803100215.GT853475@embecosm.com> References: <69e3904db9020da1941ec91e4b4b9c1ea2a6493d.1588245462.git.andrew.burgess@embecosm.com> <685b3981-8a03-ff1b-ce22-a7fd101c6fef@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <685b3981-8a03-ff1b-ce22-a7fd101c6fef@simark.ca> X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 10:57:54 up 15 days, 19:12, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2020 10:02:19 -0000 * Simon Marchi [2020-07-31 17:34:06 -0400]: > On 2020-04-30 7:20 a.m., Andrew Burgess wrote: > > Building on the previous commit, this patch detects when two tests > > have the same test name and causes Dejagnu to print a new result type > > '# of duplicate test names' in the result summary. A line starting > > with 'DUPLICATE: ' is also added to the gdb.sum and gdb.log files. > > > > The DUPLICATE markers will be printed the second time a duplicate test > > name is seen, and every time after that. So you might see: > > > > PASS: gdb.base/sometest.exp: foo > > PASS: gdb.base/sometest.exp: bar > > PASS: gdb.base/sometest.exp: foo > > DUPLICATE: gdb.base/sometest.exp: foo > > PASS: gdb.base/sometest.exp: baz > > PASS: gdb.base/sometest.exp: foo > > DUPLICATE: gdb.base/sometest.exp: foo > > > > However, the results will report a duplicate count of 1, indicating > > that just one test name (foo) was duplicated. > > > > Currently if the tests are run in parallel mode the new result type is > > not merged into the combined summary file so users will need to run in > > non-parallel mode to check this result. Similarly, the 'DUPLICATE: ' > > markers will not be merged into the final gdb.sum file. A later > > commit will fix this. > > Hi Andrew, > > When testing on Red Hat 7.8 (machine gcc135), I get this, which I think is related to this > change. > > Running /home/simark/src/binutils-gdb/gdb/testsuite/gdb.ada/O2_float_param.exp ... > can't unset "all_test_names": no such variable > while executing > "unset all_test_names" > > This machine has Dejagnu 1.5.1, which I suppose is the version that comes with this distro > version. `all_test_names` is local to gdb/testsuite/lib/check-test-names.exp, so shouldn't depend on the version of dejagnu being run. I tried installing version 1.5.1 of dejagnu, and as expected that works fine. My guess is that this is either a problem with an older version of tcl, or maybe expect (?) Or else, there's something specific about exactly what test you're running, with the particular settings you're using that's triggering this issue. Can you include the output of `runtest --version` so we can see which tcl/expect are being used, and provide the full `make check` command you're running. Thanks, Andrew