From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH v2 11/12] Set inferior_ptid in ravenscar_thread_target::update_thread_list
Date: Wed, 5 Aug 2020 13:08:40 -0600 [thread overview]
Message-ID: <20200805190841.2506771-12-tromey@adacore.com> (raw)
In-Reply-To: <20200805190841.2506771-1-tromey@adacore.com>
Commit 2da4b788f ("Don't write to inferior_ptid in
ravenscar-thread.c") caused a Ravenscar regression (which, FWIW, is
understandable because Ravenscar is difficult to test). Namely,
ravenscar_thread_target::update_thread_list calls
iterate_over_live_ada_tasks, which calls ada_build_task_list, which
uses target_has_stack -- which relies on inferior_ptid.
This patch changes update_thread_list to ensure that inferior_ptid is
set before making this call. This avoids various failures on
Ravenscar targets.
2020-07-08 Tom Tromey <tromey@adacore.com>
* ravenscar-thread.c (update_thread_list): Set inferior_ptid.
---
gdb/ChangeLog | 4 ++++
gdb/ravenscar-thread.c | 6 ++++++
2 files changed, 10 insertions(+)
diff --git a/gdb/ravenscar-thread.c b/gdb/ravenscar-thread.c
index 459e5ea3ed3..37df2188cf3 100644
--- a/gdb/ravenscar-thread.c
+++ b/gdb/ravenscar-thread.c
@@ -419,6 +419,12 @@ ravenscar_thread_target::add_thread (struct ada_task_info *task)
void
ravenscar_thread_target::update_thread_list ()
{
+ /* iterate_over_live_ada_tasks requires that inferior_ptid be set,
+ but this isn't always the case in target methods. So, we ensure
+ it here. */
+ scoped_restore save_ptid = make_scoped_restore (&inferior_ptid,
+ m_base_ptid);
+
/* Do not clear the thread list before adding the Ada task, to keep
the thread that the process stratum has included into it
(m_base_ptid) and the running thread, that may not have been included
--
2.26.2
next prev parent reply other threads:[~2020-08-05 19:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 19:08 [PATCH v2 00/12] Fix Ravenscar regressions Tom Tromey
2020-08-05 19:08 ` [PATCH v2 01/12] Call add_active_thread after pushing the ravenscar target Tom Tromey
2020-08-05 19:08 ` [PATCH v2 02/12] Avoid crash in ravenscar_thread_target::wait Tom Tromey
2020-08-05 19:08 ` [PATCH v2 03/12] Return event_ptid from ravenscar_thread_target::wait Tom Tromey
2020-08-05 19:08 ` [PATCH v2 04/12] Handle case where Ada task is current but not listed Tom Tromey
2020-08-05 19:08 ` [PATCH v2 05/12] Change names given to Ravenscar threads Tom Tromey
2020-08-05 19:08 ` [PATCH v2 06/12] Use gdb::function_view in iterate_over_live_ada_tasks Tom Tromey
2020-08-05 19:08 ` [PATCH v2 07/12] Wrap xfer_partial and enable_btrace for Ravenscar Tom Tromey
2020-08-05 19:08 ` [PATCH v2 08/12] Update Ravenscar documentation Tom Tromey
2020-08-05 19:08 ` [PATCH v2 09/12] Fix Ravenscar "process" resume Tom Tromey
2020-08-05 19:08 ` [PATCH v2 10/12] Fetch registers from correct thread in ravenscar-thread.c Tom Tromey
2020-08-05 19:08 ` Tom Tromey [this message]
2020-08-05 19:08 ` [PATCH v2 12/12] Fix remaining Ravenscar regressions Tom Tromey
2020-08-07 15:03 ` [PATCH v2 00/12] Fix " Joel Brobecker
2020-08-07 16:26 ` Tom Tromey
2020-08-07 17:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805190841.2506771-12-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).