From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 7C7B33851C0E for ; Fri, 7 Aug 2020 12:36:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7C7B33851C0E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=mittosystems.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jozef.l@mittosystems.com Received: by mail-wm1-x332.google.com with SMTP id c80so1608167wme.0 for ; Fri, 07 Aug 2020 05:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mittosystems.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JCmQdbY0ya9n4kbfcU2vnieby1xsDbBJXvN3QiQqVQE=; b=XfbnId6hEwi8/dQXw0chkADhKHRum2RZb9XteirY1RB4AW/SucQhDLw0+kigkfRQ3E kMjXIRaKXQJ1v/+FbgDJFfQYhm1AQfQVJio3HDvmd2WUTbvhQtXrJvpDEiyGD+oT3Oog m25wtCga9vNh0Dccf/+C2dPJjK5V+M7cXaXWvhGZjJlJJrKQoyZ290SNplT7YXoLEw26 6yzY0FA4WR0Ajruto1UMFz0nfqzZ/XviVLn66OmgPJ8nRdKzWOyCBHArVaJ56sSJf0nE 2WIssNXg9bYFYgex9yLWvworMpt0pap2nqrrHiyejTo12C15Iqc/HGhfEBJcLXzX7Eos J2TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JCmQdbY0ya9n4kbfcU2vnieby1xsDbBJXvN3QiQqVQE=; b=PDsxJ6IQyTuU3JIUUxd7bqePYiNU9K1v5QmfrtxLr60IWeZdzDulugDxCxHiO8DPwJ EmcmoLqUyIdrTTYsuQTeUsqL9He7JPT2PYVUatwfcOAETo2pgILTibenDGeRTK6mByUi OM6YHpT01EBQiTjJnRWyO3uW7gCtNyBANpl+bYP/+sgbTBBS9sx8yitdDY7TzGi+kUye nz/2S5uWTxS9n99rFDAyHneO0EIACzDVxAT5f+UJ35Y2YSHkJZsYZI3L7PVSE2r3pOL9 CWbdkgd0sRXYVPN7WTJU4Co0QHQ20mWa74vTR3UjJHZgJgCmeCngl+MDOSXP4V9y1ZE/ yM0Q== X-Gm-Message-State: AOAM5300iUM+QpmoDtAqlfG3PTXwD2XuxEy2w6gNZ6W3RzLSwWRjdG5R L86wS41NNZj4SckwRIG4JvQw5cCZcks= X-Google-Smtp-Source: ABdhPJz0fbljTsRF7NcMldNaec9UxQ2gAhX8F1KQQCDqQf3kVlshJP+DDnttX6axZq/kBiwDLJCcWQ== X-Received: by 2002:a1c:1d92:: with SMTP id d140mr12795896wmd.143.1596803796632; Fri, 07 Aug 2020 05:36:36 -0700 (PDT) Received: from jozef-acer-manjaro ([2a01:4b00:87fd:900:5e1d:5c99:56da:76e8]) by smtp.gmail.com with ESMTPSA id x2sm10902611wrg.73.2020.08.07.05.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 05:36:36 -0700 (PDT) Date: Fri, 7 Aug 2020 13:36:34 +0100 From: Jozef Lawrynowicz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [committed] MSP430: sim: Increase main memory region size Message-ID: <20200807123634.rwbk7dfzgn2u2svh@jozef-acer-manjaro> References: <20200807100637.2wrbpxx53i57vl7p@jozef-acer-manjaro> <87364ymyaq.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87364ymyaq.fsf@tromey.com> X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2020 12:36:40 -0000 Hi, On Fri, Aug 07, 2020 at 06:32:29AM -0600, Tom Tromey wrote: > >>>>> "Jozef" == Jozef Lawrynowicz writes: > > I don't know much about MSP430 or the sim, but I noticed a little > oddity: > > Jozef> The area between 0xFF00 and 0xFFC0 is unallocated in the simulator > Jozef> memory map, so extend the main memory region up to 0xFFC0 to allow the > Jozef> simulator to make use of the extra 192 bytes of space. > > The intro text says 0xFFC0... > > Jozef> + sim_do_commandf (sd, "memory-region 0x500,0xfac0"); /* RAM and/or ROM */ > > ... but the patch says 0xfac0. I think one or the other should be > changed. The memory-region command takes an origin address and size as arguments, in the same way a linker script memory map does. So 0xfac0 is not the end of the region, but the size of the region, and of course 0x500 + 0xfac0 = 0xffc0. Thanks, Jozef > > Tom