From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 2389C39450EE for ; Fri, 28 Aug 2020 14:39:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2389C39450EE Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-92-_bczv95wNEmjUwBsZDcHFQ-1; Fri, 28 Aug 2020 10:39:01 -0400 X-MC-Unique: _bczv95wNEmjUwBsZDcHFQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DE73980EDA5; Fri, 28 Aug 2020 14:39:00 +0000 (UTC) Received: from blade.nx (ovpn-114-125.ams2.redhat.com [10.36.114.125]) by smtp.corp.redhat.com (Postfix) with ESMTP id AEF3D6716C; Fri, 28 Aug 2020 14:39:00 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id D36E7816CCA9; Fri, 28 Aug 2020 15:38:59 +0100 (BST) Date: Fri, 28 Aug 2020 15:38:59 +0100 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Reject ambiguous C++ field accesses Message-ID: <20200828143859.GB15596@blade.nx> References: <20200827180251.20244-1-pedro@palves.net> MIME-Version: 1.0 In-Reply-To: <20200827180251.20244-1-pedro@palves.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 14:39:05 -0000 Pedro Alves wrote: > An ambiguous access is now an error instead of a warning, and also > GDB shows you the all candidates, like: > > (gdb) print x.x > Request for member 'x' is ambiguous in type 'X'. Candidates are: > 'int A1::x' (X -> A1) > 'int A2::x' (X -> A2) > (gdb) print j.x > Request for member 'x' is ambiguous in type 'J'. Candidates are: > 'int A1::x' (J -> K -> A1) > 'int A1::x' (J -> L -> A1) That's really nice, thanks for doing this! I replied with a comment tweak in another message, but other than that and the things Luis found, LGTM. Thanks, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat