From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 490713986410 for ; Fri, 4 Sep 2020 00:30:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 490713986410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599179388; bh=vQ4eQ6pwJpljbE0X40X2KIaM36+Q86QLFRBVkF/Y98I=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=gdf8pDie+cAXefAITMKebNcKWciYDHSCoas5j6ZDdcZyuHYTRB2Hj+fBm+DVckXyQ atLjj4GAc+3OoHlTA3zTIdPSdBuvFeHk4HEDzHIj+5s4e4MzlKwE/xAY7kpw5ezQ9s y5ulaKP3Tj9fbOgzuiUC5/3NblmBWB1+gNsZDO2c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([89.79.191.25]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MrQEn-1kssn51WLf-00oYcw; Fri, 04 Sep 2020 02:29:48 +0200 From: Kamil Rytarowski To: gdb-patches@sourceware.org Cc: tom@tromey.com, tankut.baris.aktemur@intel.com, Kamil Rytarowski Subject: [PATCH v2 08/10] Avoid double free in startup_inferior Date: Fri, 4 Sep 2020 02:29:03 +0200 Message-Id: <20200904002905.13616-9-n54@gmx.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200904002905.13616-1-n54@gmx.com> References: <20200904002905.13616-1-n54@gmx.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Kr/XEifRcFAG9ZXUgghPjk/Ez/OsFuYCQj9jBvZou5Z9W/ZLegX urH2vGqdL1htE9666tK9gT/qW6z2pfmcVPjm4UOyX688qnPtyAu4+1IRH6zUzTh38h9NuFF CXXx855xE5oExw837DwiBpjmrr8tpFy8+AJlB3MlQp5zWdAIhYmTmcuGu7a81bND/SH6aql 7etidY54+XVk5Bz31AX+Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:XuznUOspp7A=:Cd+X2kRq4mtknNU1SdnhUq b9L7hvO5g1tlBFSK3PcfCaoGwHeSdWvMz19FPIaalby297J4fdOkvlyDBH79Vge5BSFyx0siG +wTbz/QcQNfG7oFub/48afRgdUhsIZyX/Prp0YNXLBmbjBcVnieeKxqfyg9a9vevu1tXgNoaa +gjuzKy3nw4GKoWruR5PLqMDBJuRkvQcB1vnHPlerSRWm5KuB4SQn+2/TjjeX9MHtrn1WiB3c +DqbASZAj4/8faAUgwEo0g8qX3Hm+Z7I8fkQTsGGZaIvQB0effw67mpeefuW3GrZvMVVW0ejo 1uVar0k9r3B8SMDLKaV6MIJh/NklUjC0s4bR3bvOawTto224+mxmR05rfaoc7jedPJ4aGz2aR n5IV9Ffhr82vCQ0/XEz5x9gLOJHpVy6salaXeolnhtLwhZwXCpLKdCAX1Kncez+3lcMwsxVpn /Fy+GeqBWCHmS7nbqjuoggnNxDQ0CngXQ4Sa8qwnInXWLvMYmewrbevNyc4C4GhNVNTvDgSol L/rf2S56Wbyi3GmubAFTPTWu+wEVZKolA+CGDKBoYeZkaEgPNzUUxszJisAP1M0sKQg/BMVga XMKDCinPrEbPbLh7dGVMkKjPzyJJodb0uYqMgy3XBl2Dp7KSpTskJsPUSHm0xClBQPh2F2gWw uzyFfM4RZaqz8f0DpPAOsRc/vEP88hHhcwxPzhpO8UHbyN6Ecz06XI4uU9OUTX/Uk3d9m/nsM LJZze+XPDR059peazsoBpp2lOhxgBH2pMfy+pKx4iZCfrvlF7HgAdVCA7ktN7lyVkbda0WNYc TYXv+kgPSMc7cNF3t6Q0cLJEBKDH5ykSeVtWpUVt+cKIW/p2C3g1SnztB4/FaihBdYOCyFE7X oFp4Akuan3zBykmaoCc/q7xJGRlYTjBT4F0EbV+zk3wwObXsWYPm1StN3jVSSiXmNouX/KiXa ftoAHSatBexy9rbtpZj8YjEBxmonicLC1Fs3zPh/ln6bjtXWVzLTMTM+SAo15Ndl0/BlUsjZQ Y5Zb3V0mBKjU0U09WPFAzGnKazqtSp7mE9YNsW4Tg0CoJG2IXmW5yRZ0evUts7sMEV4GsQWs/ UQWs4IGsOsSgzA+wIkW1Uro711KHKgGFFwUPT0AUFUdRWBDr9sAbRkEQzkBwFv7ukWZ4VlSgj fwEo746dhs4UP3kmAWjibuKPD2UhoJmWJP1VA8hbpGtUpCbzkpF19Vh8uuCqeImxMjbLE+DPX M0PO71q6bfb7hiLZh X-Spam-Status: No, score=-17.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Sep 2020 00:30:06 -0000 Do not free the last execd pathname as it will be used in prepare_resume_reply(), after attaching a client side. gdb/ChangeLog: * fork-inferior.c (startup_inferior): Avoid double free. =2D-- gdb/ChangeLog | 4 ++++ gdb/nat/fork-inferior.c | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b96e7bf08e8..1013f6a0b3c 100644 =2D-- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-09-04 Kamil Rytarowski + + * fork-inferior.c (startup_inferior): Avoid double free. + 2020-09-04 Kamil Rytarowski * netbsd-nat.h (netbsd_nat::qxfer_siginfo): Add. diff --git a/gdb/nat/fork-inferior.c b/gdb/nat/fork-inferior.c index 1185ef8998b..94ab0b9cbc2 100644 =2D-- a/gdb/nat/fork-inferior.c +++ b/gdb/nat/fork-inferior.c @@ -526,7 +526,10 @@ startup_inferior (process_stratum_target *proc_target= , pid_t pid, int ntraps, case TARGET_WAITKIND_EXECD: /* Handle EXEC signals as if they were SIGTRAP signals. */ - xfree (ws.value.execd_pathname); + /* Do not free the last execd pathname as it will be used in + prepare_resume_reply(), after attaching a client side. */ + if (pending_execs !=3D 1) + xfree (ws.value.execd_pathname); resume_signal =3D GDB_SIGNAL_TRAP; switch_to_thread (proc_target, event_ptid); break; =2D- 2.28.0