From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by sourceware.org (Postfix) with ESMTPS id 7B3C43870910 for ; Mon, 7 Sep 2020 07:57:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7B3C43870910 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x443.google.com with SMTP id c15so14685617wrs.11 for ; Mon, 07 Sep 2020 00:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wNo3yNk4vkRG9N3YPsXxW+3HdV3CZszMaKLLmJqUgFU=; b=A4MEMlAB3s+3poaXr1s7100/jgrf+vQslGA/gskMQKVRD5HjD2ptYtzDzEHzoZLsJO 5klmHun7arETJUe0DcDiUb+Uhf3LaB6KpwIqKPcH2BrVBdeTKzsWahWKpUfPAlUE90sP 2gij4V1bk+lBTHXyMD0NUn+RLKcwY6xnheKR1G82uFpuRhYkItKRp/3mpkdTjQjSKE7l 98OsZf3IHfAF5GjrosCLHCYkHaLAipBx0cCRs3QMQ0w1cH7X0G+YlUJYR/OrRUioY47C tZETE0WazZo55rxJOS+Z6qQp8cUz+Tgwvh4FhtILYRAzKbcPyI+IZK90K1M7ggDJ7fdK S7iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wNo3yNk4vkRG9N3YPsXxW+3HdV3CZszMaKLLmJqUgFU=; b=ZSBCyrtNhYdBRCrtjFTU/13XEykiVsNs4NjM7sBaUStAMMosWp5dVvK0hIBEMR8WIp 3+paOjy/+4nz0rUC2r5EFLAo+yZpGHMcVYcAayV80EkWgA7pcOxS55x2WIi4yYOWmXZl JZsGQ/kJ9ErVLhgpmF843XJ8aEoTlTOoPflgFFAxY1pGlimZZifRNCjqRe65aiZK9Rlh Jg5VrNPRsd3bQzfI/163iFuKtxlGrs89ieEBf53vdzDUozSkuy1xh5kgIOQ9AlWvFUdb eo9UxYUKxmX7n+TSn+Q18TlV80yOEwcTGTYIU6oxVpMtKfJH68urdIrg6CrVaAtp+EBm Zo0g== X-Gm-Message-State: AOAM532k8IaVR8CwHGIFiats8BEdQVQhNN0cba66fHE058+/cM13kavc fPte7aouOAJNSdiLA9/pHx5ujA== X-Google-Smtp-Source: ABdhPJxukCPtriuoWcaCI4qrq1j0FKkxs20RsLwpDjrDWpRkYdJCrWtrbl/5tziqd471NKorSlyB7A== X-Received: by 2002:a05:6000:1ce:: with SMTP id t14mr19135299wrx.195.1599465463627; Mon, 07 Sep 2020 00:57:43 -0700 (PDT) Received: from localhost (host81-151-181-130.range81-151.btcentralplus.com. [81.151.181.130]) by smtp.gmail.com with ESMTPSA id d13sm1539206wrp.44.2020.09.07.00.57.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 00:57:42 -0700 (PDT) Date: Mon, 7 Sep 2020 08:57:41 +0100 From: Andrew Burgess To: Kamil Rytarowski Cc: gdb-patches@sourceware.org, tom@tromey.com Subject: Re: [PATCH v2 04/10] Add netbsd_nat::pid_to_exec_file Message-ID: <20200907075741.GG853475@embecosm.com> References: <20200904002905.13616-1-n54@gmx.com> <20200904002905.13616-5-n54@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200904002905.13616-5-n54@gmx.com> X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 08:56:39 up 50 days, 17:11, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2020 07:57:45 -0000 * Kamil Rytarowski [2020-09-04 02:28:59 +0200]: > gdb/ChangeLog: > > * netbsd-nat.h: Include . > * (netbsd_nat::pid_to_exec_file): Add. > * netbsd-nat.c: Include and . > * (netbsd_nat::pid_to_exec_file) Add. > --- > gdb/ChangeLog | 7 +++++++ > gdb/nat/netbsd-nat.c | 18 ++++++++++++++++++ > gdb/nat/netbsd-nat.h | 5 +++++ > 3 files changed, 30 insertions(+) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 9e9d4e16e5d..335d6b7271f 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,10 @@ > +2020-09-04 Kamil Rytarowski > + > + * netbsd-nat.h: Include . > + * (netbsd_nat::pid_to_exec_file): Add. > + * netbsd-nat.c: Include and . > + * (netbsd_nat::pid_to_exec_file) Add. > + > 2020-09-04 Kamil Rytarowski > > * configure.nat (NATDEPFILES): Add nat/netbsd-nat.o when needed. > diff --git a/gdb/nat/netbsd-nat.c b/gdb/nat/netbsd-nat.c > index 2b5a4183e30..297188bb8b4 100644 > --- a/gdb/nat/netbsd-nat.c > +++ b/gdb/nat/netbsd-nat.c > @@ -19,6 +19,24 @@ > > #include "nat/netbsd-nat.h" > > +#include > +#include > + > namespace netbsd_nat > { > + > +/* Return the executable file name of a process specified by PID. Returns the > + string in a static buffer. */ > + > +char * > +pid_to_exec_file (pid_t pid) The convention in GDB is to document global functions in the header file, and leave a comment '/* See xxxx.h. */' in the source file. Thanks, Andrew > +{ > + static char buf[PATH_MAX]; > + int mib[4] = {CTL_KERN, KERN_PROC_ARGS, pid, KERN_PROC_PATHNAME}; > + size_t buflen = sizeof (buf); > + if (::sysctl (mib, ARRAY_SIZE (mib), buf, &buflen, NULL, 0)) > + return NULL; > + return buf; > +} > + > } > diff --git a/gdb/nat/netbsd-nat.h b/gdb/nat/netbsd-nat.h > index 5fa08746610..a5f664d95f4 100644 > --- a/gdb/nat/netbsd-nat.h > +++ b/gdb/nat/netbsd-nat.h > @@ -20,8 +20,13 @@ > #ifndef NAT_NETBSD_NAT_H > #define NAT_NETBSD_NAT_H > > +#include > + > namespace netbsd_nat > { > + > +extern char *pid_to_exec_file (pid_t pid); > + > } > > #endif > -- > 2.28.0 >