From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 61F61388A82B for ; Tue, 8 Sep 2020 13:49:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 61F61388A82B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 20599117670; Tue, 8 Sep 2020 09:49:24 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Fo8x1h0IeU2K; Tue, 8 Sep 2020 09:49:24 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C3E191175EE; Tue, 8 Sep 2020 09:49:23 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 47A6F849D1; Tue, 8 Sep 2020 06:49:22 -0700 (PDT) Date: Tue, 8 Sep 2020 06:49:22 -0700 From: Joel Brobecker To: Simon Marchi Cc: Kamil Rytarowski , gdb-patches@sourceware.org Subject: Re: Propose GDB 10 branch this Fri-Sun (Sep 11-13) [2020-09-05 Update] Message-ID: <20200908134922.GB18641@adacore.com> References: <20200905205318.GA30158@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2020 13:49:25 -0000 > I think that's reasonable. I just finished taking a look, I did review it > as best as I could. There's not much risk in merging it, and the sooner this > is available upstream, the better, so I think we should just go ahead with it. > > Of course, the more pair of eyes on the code the better, so if somebody else > wants to take a look, go ahead. > > I would also consider including the gdbserver support for ARC, with the same > logic. But I don't think that has to block the branch creation, we can easily > cherry-pick it. I'm not opposed to these going into GDB 10 on the basis that they are isolated pieces of code that can't affect the rest. On the other hand, if those can be safely pushed at the last minute, they should also be cherry-pickable on the branch, so given the very large delay the branching has already suffered, I would not delay branching for this new feature further. We can simply cherry-pick those later. Would that be acceptable? -- Joel