From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 3B26B397202C for ; Fri, 25 Sep 2020 19:49:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3B26B397202C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 187BC117A1B; Fri, 25 Sep 2020 15:49:16 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5dCzq4ggdp-S; Fri, 25 Sep 2020 15:49:16 -0400 (EDT) Received: from murgatroyd.Home (184-96-226-199.hlrn.qwest.net [184.96.226.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id C95531179DD; Fri, 25 Sep 2020 15:49:15 -0400 (EDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2 4/6] Remove some dead code from handle_search_memory Date: Fri, 25 Sep 2020 13:49:11 -0600 Message-Id: <20200925194913.1744541-5-tromey@adacore.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200925194913.1744541-1-tromey@adacore.com> References: <20200925194913.1744541-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2020 19:49:17 -0000 handle_search_memory had some code after a call to error. This code is dead, and this patch removes it. gdbserver/ChangeLog 2020-09-25 Tom Tromey * server.cc (handle_search_memory): Remove dead code. --- gdbserver/ChangeLog | 4 ++++ gdbserver/server.cc | 9 ++------- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 1c21660027e..674462c9ae6 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -1054,11 +1054,8 @@ handle_search_memory (char *own_buf, int packet_len) pattern = (gdb_byte *) malloc (packet_len); if (pattern == NULL) - { - error ("Unable to allocate memory to perform the search"); - strcpy (own_buf, "E00"); - return; - } + error ("Unable to allocate memory to perform the search"); + if (decode_search_memory_packet (own_buf + cmd_name_len, packet_len - cmd_name_len, &start_addr, &search_space_len, @@ -1066,8 +1063,6 @@ handle_search_memory (char *own_buf, int packet_len) { free (pattern); error ("Error in parsing qSearch:memory packet"); - strcpy (own_buf, "E00"); - return; } auto read_memory = [] (CORE_ADDR addr, gdb_byte *result, size_t len) -- 2.26.2