From: Shahab Vahedi <shahab.vahedi@gmail.com>
To: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>,
Simon Marchi <simark@simark.ca>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Anton Kolesov <Anton.Kolesov@synopsys.com>,
Shahab Vahedi <shahab@synopsys.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: Re: [PATCH] arc: Add support for Linux coredump files
Date: Tue, 29 Sep 2020 11:02:57 +0200 [thread overview]
Message-ID: <20200929090257.GC4717@gmail.com> (raw)
In-Reply-To: <20200929082456.GB4717@gmail.com>
On Tue, Sep 29, 2020 at 10:24:59AM +0200, Shahab Vahedi wrote:
> "the_target->read_memory()" and "read_memory()" should be the
> same in terms of code execution (not code writing). Then,
> there is "target_read_memory()" which I think is the default
> implementation [3].
>
> [3]
> "process_stratum_target" class (the base) provides
> "read_memory()" as pure virtual method. Therefore, it must be defined
> overridden somewhere and I _think_ this is the default implementation.
To be correct, they are NOT the same:
the_target->read_memory --> linux-low.cc: linux_process_target::read_memory
target_read_memory --> target.cc: read_inferior_memory
The second is a wrapper around the first one with some sanity checks.
This supports my previous decision to using it.
Cheers,
Shahab
next prev parent reply other threads:[~2020-09-29 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 11:27 Shahab Vahedi
2020-09-07 9:14 ` Shahab Vahedi
2020-09-16 2:31 ` [PING^2][PATCH] " Shahab Vahedi
2020-09-16 20:21 ` [PATCH] " Simon Marchi
2020-09-17 11:55 ` Aktemur, Tankut Baris
2020-09-28 13:47 ` Shahab Vahedi
2020-09-28 14:08 ` Aktemur, Tankut Baris
2020-09-28 19:10 ` Simon Marchi
2020-09-29 8:24 ` Shahab Vahedi
2020-09-29 9:02 ` Shahab Vahedi [this message]
2020-09-29 14:22 ` Simon Marchi
2020-09-29 15:42 ` Shahab Vahedi
2020-10-01 13:30 ` Shahab Vahedi
2020-09-29 16:15 ` [PATCH v2] " Shahab Vahedi
2020-10-05 2:13 ` Simon Marchi
2020-10-07 16:11 ` [PUSHED master] " Shahab Vahedi
2020-10-07 16:32 ` [PUSHED gdb-10-branch] " Shahab Vahedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929090257.GC4717@gmail.com \
--to=shahab.vahedi@gmail.com \
--cc=Anton.Kolesov@synopsys.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab@synopsys.com \
--cc=simark@simark.ca \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).