From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 76A693850420 for ; Wed, 30 Sep 2020 10:00:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 76A693850420 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-yiW-xSXPMDymLqg2cMX7xQ-1; Wed, 30 Sep 2020 06:00:20 -0400 X-MC-Unique: yiW-xSXPMDymLqg2cMX7xQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D32D8030BA; Wed, 30 Sep 2020 10:00:19 +0000 (UTC) Received: from blade.nx (ovpn-114-204.ams2.redhat.com [10.36.114.204]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40BE910013C4; Wed, 30 Sep 2020 10:00:19 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 5027B816CD2E; Wed, 30 Sep 2020 11:00:18 +0100 (BST) Date: Wed, 30 Sep 2020 11:00:18 +0100 From: Gary Benson To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PING][PATCH] Fix gdb.dwarf2/dw2-double-set-die-type.exp with Clang Message-ID: <20200930100018.GA3861@blade.nx> References: <1599488990-15732-1-git-send-email-gbenson@redhat.com> <20200922114611.GA11960@blade.nx> <20200926181935.GE13066@adacore.com> MIME-Version: 1.0 In-Reply-To: <20200926181935.GE13066@adacore.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2020 10:00:25 -0000 Hi Joel, Joel Brobecker wrote: > Hi Gary, > > > > gdb/testsuite/ChangeLog: > > > > > > * gdb.dwarf2/dw2-double-set-die-type.S (.Ldie_3e0): > > > Convert directive to lowercase. > > > (.Labbrev1_begin): Add missing label. > > > (abbrev code 0x1): Remove DW_AT_stmt_list. > > > (.Ldie_b): Likewise. > > Apologies for the delay in reviewing. This looks good to me. Thank you, I've pushed this now. > > > Second, I want to report these issues to the relevang upstream, > > > but I'm struggling to find documentation. Does anybody know, > > > or have an opinion about: > > > > > > 1) Is it Clang's error that it doesn't accept .Uleb128 as a > > > valid directive, or is it gas's error that it does? > > The GAS documentation gives a clue > (https://sourceware.org/binutils/docs-2.35/as/Pseudo-Ops.html#Pseudo-Ops): > > | All assembler directives have names that begin with a period > | (‘.’). The names are case insensitive for most targets, and > | usually written in lower case. > > I don't know if this means that Clang is in error however. > I don't think the targets usually define the assembly language, > particularly for the pseudo ops, do they? No, I get the impression it's always been somewhat tool-specific, though it's not a field I have any deep knowledge in. I'll take this to Clang's developers, see what they think. > > > 2) Is it Clang's error that it bombs on undefined labels, or > > > is it gas's error that it doesn't? > > That, I do not know. Sounds odd indeed that there wouldn't be an > error for those, but maybe there is something behind it. It's a > question for the binutils group, who will be better place to answer > those. I asked Nick, he said it makes sense for gas to accept undefined labels as the label could be defined in another file. So again, I'll take this to Clang's developers. Thanks for your time Joel! Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat