From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id EF8933950CB9 for ; Mon, 5 Oct 2020 16:23:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EF8933950CB9 X-ASG-Debug-ID: 1601915022-0c856e1c4511ec00001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id Vod0TGUrT9ItkGWK (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 05 Oct 2020 12:23:42 -0400 (EDT) X-Barracuda-Envelope-From: simon.marchi@efficios.com X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from smarchi-efficios.internal.efficios.com (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by smtp.ebox.ca (Postfix) with ESMTP id B2F12441B21; Mon, 5 Oct 2020 12:23:42 -0400 (EDT) From: Simon Marchi X-Barracuda-RBL-IP: 192.222.181.218 X-Barracuda-Effective-Source-IP: 192-222-181-218.qc.cable.ebox.net[192.222.181.218] X-Barracuda-Apparent-Source-IP: 192.222.181.218 To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] gdb: TYPE_VECTOR -> type::is_vector in amd64-windows-tdep.c Date: Mon, 5 Oct 2020 12:23:41 -0400 X-ASG-Orig-Subj: [pushed] gdb: TYPE_VECTOR -> type::is_vector in amd64-windows-tdep.c Message-Id: <20201005162341.2714909-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1601915022 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-Scan-Msg-Size: 1955 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.85090 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Spam-Status: No, score=-21.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2020 16:23:56 -0000 I get this build failure: CXX amd64-windows-tdep.o cc1plus: warning: command-line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++ /home/smarchi/src/binutils-gdb/gdb/amd64-windows-tdep.c: In function 'return_value_convention amd64_windows_return_value(gdbarch*, value*, type*, regcache*, gdb_byte*, const gdb_byte*)': /home/smarchi/src/binutils-gdb/gdb/amd64-windows-tdep.c:374:6: error: 'TYPE_VECTOR' was not declared in this scope 374 | if (TYPE_VECTOR (type) && len == 16) | ^~~~~~~~~~~ TYPE_VECTOR was removed in favor of the type::is_vector method. gdb/ChangeLog: * amd64-windows-tdep.c (amd64_windows_return_value): Use type::is_vector instead of TYPE_VECTOR. Change-Id: I0ce26c3f7a33625761a8dba351c3158464f21b01 --- gdb/ChangeLog | 5 +++++ gdb/amd64-windows-tdep.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 39a2cf352297..183b92970341 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-10-05 Simon Marchi + + * amd64-windows-tdep.c (amd64_windows_return_value): Use + type::is_vector instead of TYPE_VECTOR. + 2020-10-05 Simon Marchi * auto-load.c (auto_load_objfile_script_1): Don't use diff --git a/gdb/amd64-windows-tdep.c b/gdb/amd64-windows-tdep.c index 320388b5a879..48cd00955385 100644 --- a/gdb/amd64-windows-tdep.c +++ b/gdb/amd64-windows-tdep.c @@ -371,7 +371,7 @@ amd64_windows_return_value (struct gdbarch *gdbarch, struct value *function, break; case TYPE_CODE_ARRAY: /* __m128, __m128i and __m128d are returned via XMM0. */ - if (TYPE_VECTOR (type) && len == 16) + if (type->is_vector () && len == 16) { enum type_code code = TYPE_TARGET_TYPE (type)->code (); if (code == TYPE_CODE_INT || code == TYPE_CODE_FLT) -- 2.26.2