From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id AD50C3851C33 for ; Tue, 6 Oct 2020 14:12:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AD50C3851C33 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-5-sUb-NHtyN_SWaabV_tKGGQ-1; Tue, 06 Oct 2020 10:12:56 -0400 X-MC-Unique: sUb-NHtyN_SWaabV_tKGGQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E1A01084C90; Tue, 6 Oct 2020 14:12:55 +0000 (UTC) Received: from blade.nx (ovpn-113-170.ams2.redhat.com [10.36.113.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E4BD3A40; Tue, 6 Oct 2020 14:12:55 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 33FD1816CD2E; Tue, 6 Oct 2020 15:12:54 +0100 (BST) Date: Tue, 6 Oct 2020 15:12:54 +0100 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdb.base/list-ambiguous.exp with Clang Message-ID: <20201006141254.GA8332@blade.nx> References: <1601896635-14556-1-git-send-email-gbenson@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2020 14:12:59 -0000 Pedro Alves wrote: > On 10/5/20 12:17 PM, Gary Benson via Gdb-patches wrote: > > The ambiguous variable parts of gdb.base/list-ambiguous.exp failed > > when built with Clang because the variable in question was unused > > and was optimized out. This commit adds __attribute__ ((used)) to > > both definitions. > > > > Checked on Fedora 32 x86_64, with GCC and Clang. Ok to commit? > > OK. Thanks Pedro, I've pushed this now. Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat