From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by sourceware.org (Postfix) with ESMTPS id A16D5385700C for ; Tue, 6 Oct 2020 15:25:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A16D5385700C Received: by mail-ej1-x641.google.com with SMTP id p15so18244702ejm.7 for ; Tue, 06 Oct 2020 08:25:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rAQ1cQcLzQY+Ea7dk/E0hpHppPC0qFaFScxxUDWxEjo=; b=IpF4FA5vQiapBJZrH5FxPEhZ+pFIXIATt/GqkQ54aYXezvDIOqu/w1Ne6Q7YR7pJx0 ASV/kZ6CeQuAmX/h0R3XDQMk7rusoIniz99KL3rEoyfvpq80koMCHKn3m3GoT7IC3Yo4 7CEz5qDcbuBrjUNJv0aR6szkIdGDz+Wvq5uzHRYaR8+uP2Stk2b/t9JZpT6cLdjRYDh6 Hx0qVVvCeWLQdYGrkyf/jl3KFAFTncONpFpZRxJ26FNrmleCFPBl5pX9GJKgo6W4t7EP RlCoredOclBcYyoZhDxforKlERAKgyB/KJsIPsBvQMxlutQ5cTZ+xbKjW59TXFi3GIiu BI8Q== X-Gm-Message-State: AOAM531kWbgpv1t8Zjo1CDPsvS/keaJpVxxZwiF3Y69VTK3O1jbOZlEt UjGJhS7gLAh9XkCWGHQkBcGgxUVlAlmcRA== X-Google-Smtp-Source: ABdhPJxrOon8/9EMZQ4i0sKgLO0dLBokNyT2neINoPLDpte3NYy7IXJfKwj3iiThnIS68URUVNKx8Q== X-Received: by 2002:a17:906:b04e:: with SMTP id bj14mr35967ejb.254.1601997944256; Tue, 06 Oct 2020 08:25:44 -0700 (PDT) Received: from atlantis.home ([2a03:1b20:3:f011::6d]) by smtp.gmail.com with ESMTPSA id ss7sm410404ejb.28.2020.10.06.08.25.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Oct 2020 08:25:43 -0700 (PDT) From: Shahab Vahedi To: gdb-patches@sourceware.org Cc: Shahab Vahedi , Shahab Vahedi , Simon Marchi , Baris Aktemur , Francois Bedard Subject: [PUSHED] gdbserver: Remove unused argument in register_data() Date: Tue, 6 Oct 2020 17:25:37 +0200 Message-Id: <20201006152537.13798-1-shahab.vahedi@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201006112016.26534-1-shahab.vahedi@gmail.com> References: <20201006112016.26534-1-shahab.vahedi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2020 15:25:47 -0000 From: Shahab Vahedi The register_data() function in gdbserver/regcache.cc has an input argument called "fetch". This argument is not used by this static function at all. Therefore, it is time to get rid of it. gdbserver/ChangeLog: * regcache.cc (register_data): Remove unused "fetch" argument. --- gdbserver/ChangeLog | 4 ++++ gdbserver/regcache.cc | 14 +++++++------- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index 1f3652b6d5d..d4e8e52c74e 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2020-10-06 Shahab Vahedi + + * regcache.cc (register_data): Remove unused "fetch" argument. + 2020-10-02 Simon Marchi * server.cc (handle_monitor_command): Handle "set diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index 6c0af95b34e..add826b2897 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -300,7 +300,7 @@ regcache_register_size (const struct regcache *regcache, int n) } static unsigned char * -register_data (const struct regcache *regcache, int n, int fetch) +register_data (const struct regcache *regcache, int n) { return (regcache->registers + find_register_by_number (regcache->tdesc, n).offset / 8); @@ -319,7 +319,7 @@ regcache::raw_supply (int n, const void *buf) { if (buf) { - memcpy (register_data (this, n, 0), buf, register_size (tdesc, n)); + memcpy (register_data (this, n), buf, register_size (tdesc, n)); #ifndef IN_PROCESS_AGENT if (register_status != NULL) register_status[n] = REG_VALID; @@ -327,7 +327,7 @@ regcache::raw_supply (int n, const void *buf) } else { - memset (register_data (this, n, 0), 0, register_size (tdesc, n)); + memset (register_data (this, n), 0, register_size (tdesc, n)); #ifndef IN_PROCESS_AGENT if (register_status != NULL) register_status[n] = REG_UNAVAILABLE; @@ -340,7 +340,7 @@ regcache::raw_supply (int n, const void *buf) void supply_register_zeroed (struct regcache *regcache, int n) { - memset (register_data (regcache, n, 0), 0, + memset (register_data (regcache, n), 0, register_size (regcache->tdesc, n)); #ifndef IN_PROCESS_AGENT if (regcache->register_status != NULL) @@ -420,7 +420,7 @@ collect_register (struct regcache *regcache, int n, void *buf) void regcache::raw_collect (int n, void *buf) const { - memcpy (buf, register_data (this, n, 1), register_size (tdesc, n)); + memcpy (buf, register_data (this, n), register_size (tdesc, n)); } enum register_status @@ -461,7 +461,7 @@ regcache_raw_get_unsigned_by_name (struct regcache *regcache, void collect_register_as_string (struct regcache *regcache, int n, char *buf) { - bin2hex (register_data (regcache, n, 1), buf, + bin2hex (register_data (regcache, n), buf, register_size (regcache->tdesc, n)); } @@ -508,7 +508,7 @@ regcache::raw_compare (int regnum, const void *buf, int offset) const { gdb_assert (buf != NULL); - const unsigned char *regbuf = register_data (this, regnum, 1); + const unsigned char *regbuf = register_data (this, regnum); int size = register_size (tdesc, regnum); gdb_assert (size >= offset); -- 2.28.0