public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Hannes Domani <ssbssa@yahoo.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/2] Remove gdb_assert for TYPE_CODE_METHOD in stabs reader
Date: Tue,  6 Oct 2020 17:49:28 +0200	[thread overview]
Message-ID: <20201006154928.3298-2-ssbssa@yahoo.de> (raw)
In-Reply-To: <20201006154928.3298-1-ssbssa@yahoo.de>

It's possible to come across TYPE_CODE_UNDEF at this point in
read_member_functions, which according to a comment in read_type
is used for forward references.

gdb/ChangeLog:

2020-10-06  Hannes Domani  <ssbssa@yahoo.de>

	* stabsread.c (read_member_functions): Remove gdb_assert.
---
 gdb/stabsread.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gdb/stabsread.c b/gdb/stabsread.c
index d2ff54a47b..a7f4ee0a8c 100644
--- a/gdb/stabsread.c
+++ b/gdb/stabsread.c
@@ -2331,9 +2331,6 @@ read_member_functions (struct stab_field_info *fip, const char **pp,
 	  /* These are methods, not functions.  */
 	  if (new_sublist->fn_field.type->code () == TYPE_CODE_FUNC)
 	    new_sublist->fn_field.type->set_code (TYPE_CODE_METHOD);
-	  else
-	    gdb_assert (new_sublist->fn_field.type->code ()
-			== TYPE_CODE_METHOD);
 
 	  /* If this is just a stub, then we don't have the real name here.  */
 	  if (TYPE_STUB (new_sublist->fn_field.type))
-- 
2.27.0


  reply	other threads:[~2020-10-06 15:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201006154928.3298-1-ssbssa.ref@yahoo.de>
2020-10-06 15:49 ` [PATCH 1/2] Don't create _Complex type name if there is no target type name Hannes Domani
2020-10-06 15:49   ` Hannes Domani [this message]
2020-10-22 17:21     ` [PATCH 2/2] Remove gdb_assert for TYPE_CODE_METHOD in stabs reader Tom Tromey
2020-10-22 17:21   ` [PATCH 1/2] Don't create _Complex type name if there is no target type name Tom Tromey
2020-10-22 17:40     ` Hannes Domani
2020-10-22 17:46       ` Tom Tromey
2020-10-22 18:20         ` Hannes Domani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006154928.3298-2-ssbssa@yahoo.de \
    --to=ssbssa@yahoo.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).