From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id 3FA543857819 for ; Wed, 7 Oct 2020 13:25:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3FA543857819 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602077110; bh=eJGL2Iqw4DLdVdsMyHPittqQXlxsXno2bv4I+TXgjUE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=Pr9BPB5nyzE+jziGqPmj3J5kYhhWI+2WxJjb8Z0vKAaCCMpyYmShBlQBJRCq1n7b8 cOY6heqND2/Jgf1jjZXlCC9R/p+JRNWq6wluCj7BPXsxEDE37lYsmlEZgwL/XHoAjp nwgG/yjyn+gHCfieSeTbKqd3fBEp971wvfEdXxeI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([89.79.191.25]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MLzFr-1k8Cwu4BDF-00HyZT; Wed, 07 Oct 2020 15:25:10 +0200 From: Kamil Rytarowski To: gdb-patches@sourceware.org Subject: [PATCH] Correct logical error in NetBSD's read_memory and write_memory Date: Wed, 7 Oct 2020 15:24:11 +0200 Message-Id: <20201007132410.5068-1-n54@gmx.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:QcMMq0ZsPRXr/lUduKXNjCOkYdrtHukWg5//1a5C34Bx7HQevSc 9UzA3AXe+oxO2qd8DnUPTrnBBHbiocgEV/iIXdwSHL7mujZxyxmYzYTVVDOA/u++wrQcx2l jTiVm5tj99PN1G35X+QDoDNGwcBGrxIqPreh3G27oPI+6mISg7XE1zLwd4+Zbnm9NRwbHqy d/YVF1FF/ZQw+FPU/MAKQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:FWpui3EWkzI=:KOFoe7ug3NbszguVyFHN6O NydiwJc/kgM+J6XXE5IepUphtUUzVqanH1xKE8XVD5Q2PRlWJV2DxpJJfEn4+3BBlcBRqTjAs q9PgBIGUZ/NQU3VRkDTxpvVCrbvUh7pAdI32XJxnG2DagwCgJ0ZJYisRLaWOTKSN6ALPoYmLh iF2+ln4LnMIvcg3SlUld0tICmGCqu9/sSfuh8YC02N+RYSWRlWstxXl55AVUoFgl+TXxBKtfL iordE6FRJNFDt72YO4qlB/xr9StAVzrZpNHtlRW1ScdW6VAC9nFnGBExRczTdQG3a0vz9npOG rFMFhCq36HrLVqTJokHp6Dv3JzLGVZVvUHKegIX5zPzZIJw8M8lhIa3lAiy7nO23rL/74kSZo HC/0UR6R8x6UFH5HLinCa0vETH7CQSClJH3J4SJP+igHyPD5fewkuOy9E1m4phboFbrT0PUSu 6pJOfKirfeEh27za8ijoHE7PASraaQ4tKpy7T3KDTnP/t2RNRR5mvuMHsL0zCvtf97KbkIV5z Wx3F0E08zwhBkqMGZL1v0NQR3HA/lI743MWfF7KJUysYbzn7BWTfXt6qZJTA3JYD6aZJrqIGG SNUrGW0xL+rHt7j+fGzB6hfrwGRK/xA5MJEWIVblx9a7XDr5q8z1NC3pVFZWbw1YQkODSxptv Ius7JLOKgOD3wgkkIPWrsV142PAYI/Ek9QnjLYTBRUJvYpW4AqLeI+6MNp/ElF9KGRt+stzGn mQ6Xe4zi9dUC6DMYATdK/aY2kq6puItPsGtCM6qAWTWKqzGdxLToloYYfV2K3+suDaUzKh5GZ sEuxXLexZclOj3rHgAYDUm/zLeUk0lV8kfyg6WA1XcozvOmpFhUjsLPRRyDE6RgaSUXlTRax8 ljAjv3TOms5CL6wCt3HshfAv3KWEYMFXDxXLwR8S8d+2t/SZatS/WOejMLF8wSEimSHo6NuaF r24MbHrLxpJdzk9XklZj+Usnhh+vTZMUL4wegGS5MrS3EDxXsIpaZVPoLws5NZRDbCqvWsdZR uHhjk1Is6J04eXGPF2h6/htZk1wCnG+HuW03FNQckwKJKodg+66d2wHrNY4XMLXtvy/UDNwdV LdWLs+WdzfVn9n0n8MRMkm0+wLSclKMXqYhRZrok1aHWl3Ai385HOJf1nHGOXSa6D0j2vv4pN uTWE0D+V0DTr+2clMkyk4328CSqpx8M5eDlrdDhwSGV7ASFWNQqxdd8zjBLiMhCfs8j87uNuQ +ENBtxPdCGQu/OLmk X-Spam-Status: No, score=-15.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2020 13:25:15 -0000 In case of repeated ptrace PT_IO call and returning the value of transferred bytes equal to 0, do not return without setting xfered_len. Merging as obvious and hot fix. gdb/ChangeLog: * nat/netbsd-nat.c (write_memory, read_memory): Update. =2D-- gdb/ChangeLog | 4 ++++ gdb/nat/netbsd-nat.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4dc729c69bc..300bf139b7f 100644 =2D-- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-10-07 Kamil Rytarowski + + * nat/netbsd-nat.c (write_memory, read_memory): Update. + 2020-10-07 Kamil Rytarowski * nat/netbsd-nat.c (write_memory, read_memory): Add. diff --git a/gdb/nat/netbsd-nat.c b/gdb/nat/netbsd-nat.c index cae9cc2fc2c..e0b61cd4b24 100644 =2D-- a/gdb/nat/netbsd-nat.c +++ b/gdb/nat/netbsd-nat.c @@ -238,7 +238,7 @@ write_memory (pid_t pid, unsigned const char *writebuf= , CORE_ADDR offset, return errno; } if (io.piod_len =3D=3D 0) - return 0; + break; bytes_written +=3D io.piod_len; io.piod_len =3D len - bytes_written; @@ -276,7 +276,7 @@ read_memory (pid_t pid, unsigned char *readbuf, CORE_A= DDR offset, if (rv =3D=3D -1) return errno; if (io.piod_len =3D=3D 0) - return 0; + break; bytes_read +=3D io.piod_len; io.piod_len =3D len - bytes_read; =2D- 2.28.0