From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by sourceware.org (Postfix) with ESMTPS id 45B8C3857C78 for ; Fri, 9 Oct 2020 08:34:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 45B8C3857C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x342.google.com with SMTP id p15so8938588wmi.4 for ; Fri, 09 Oct 2020 01:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XVovCwsRKziNgyCe2RW0JuedqKGwVZqCHH/TSNg+W3M=; b=CWxa95qyeYyNEjseahoRdLaun3s30dGTHTzV9HQlhTB2nInF7Gjc5V/WINv1y8aNCQ Oj+0NwkazjV9WfKMIdS+B02MsCzPaXYoct18mSy1g+H0vyFq9QBRz4JW1WOTw9iN0RGc P+11cV5YwRTgx7tH//2qnY3L3CJNQIb/k17GDuQ6X6BS1833sbjWcacsmySOfr87Uo0K iRaqQxtta7ygLa4roSk2t/9B/JoHuaV3CUtNzg1wytLSUWnctmXBjwh4rIjUJ6BddV/x ETY7UprevmwC88hhhhUMxXLuEFZXzFzdoUKX/yFxTYNjSzmAWyn0UtVs4s+QpA5AUTs+ KpyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XVovCwsRKziNgyCe2RW0JuedqKGwVZqCHH/TSNg+W3M=; b=tok86EtIVgN1F4ThP+K/tuEFBKYZnckJvdMWAQ/WW0BXzPfjvOeGcuyUY+JxFx14aY rTWGy/rm8yRh4J0TV4tApQEIPRERrDpASRWgN493t3/VAT3N85uu0f8JD3C5GgPZhZiI y7hKAogrVBiMaGFSnrNr0uYbcVtznVTB8SDl3S5rRraDMlzA+zeNf1COHqf4OmiByKXo gnJIsc53pYfE4MZ0sV7Kp4rgi+Bo7k49HDa9gs1PAZLFbEOsirnIJEthvv8bHoKRTClT mxPli5Bm7PXWHg+4nvy/ZSzcP5iLOyRkn/4w4NPjBjAwHD5wEre8MlVDuWHFcqPXI61G /VJg== X-Gm-Message-State: AOAM5336gdjjmPDK3ajJUPBdzVkRQG2k0DptcrfoT3rTmoQ7DM/PpNam XztCBN3iLscVvAsKs5XSBGS1iWBJUSKywA== X-Google-Smtp-Source: ABdhPJzEKAYmnXgKk7oaCQPAnAhmRvYwdMMdX1u+q1s/VXAvcmmKoHXnWKM9qSknb7s+7fSWsRxdqA== X-Received: by 2002:a1c:2bc2:: with SMTP id r185mr4910101wmr.53.1602232478244; Fri, 09 Oct 2020 01:34:38 -0700 (PDT) Received: from localhost (host109-148-134-240.range109-148.btcentralplus.com. [109.148.134.240]) by smtp.gmail.com with ESMTPSA id m11sm10693864wmf.10.2020.10.09.01.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 01:34:37 -0700 (PDT) Date: Fri, 9 Oct 2020 09:34:36 +0100 From: Andrew Burgess To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gnulib: Ensure all libraries are used when building gdb/gdbserver Message-ID: <20201009083436.GP605036@embecosm.com> References: <20201005165134.1620549-1-andrew.burgess@embecosm.com> <2feb66c2-8f65-7cbf-d1be-ae3d04b45d9a@simark.ca> <20201006121751.GK605036@embecosm.com> <95d52add-47c2-9621-7e60-1ff9a4331324@simark.ca> <20201007153319.GL605036@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201007153319.GL605036@embecosm.com> X-Operating-System: Linux/5.8.12-100.fc31.x86_64 (x86_64) X-Uptime: 09:34:15 up 6 days, 46 min, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2020 08:34:40 -0000 * Andrew Burgess [2020-10-07 16:33:19 +0100]: > * Simon Marchi [2020-10-06 10:10:25 -0400]: > > > On 2020-10-06 8:17 a.m., Andrew Burgess wrote: > > > The problem here was me unconditionally trying to include > > > Makefile.gnulib.inc from the gdb and gdbserver Makefile. The very > > > first time you run 'make clean' after applying the patch > > > Makefile.gnulib.inc doesn't exist, but the gdb/gdbserver makefiles > > > still try to pull the file in unconditionally. > > > > If the file is generated at configure-time, I think it would be ok for > > Makefile.gnulib.inc to be included unconditionally. As when you run > > "make clean" after pulling some changes, you're supposed to do to it > > from the top level, so Makefile.gnulib.inc will be created before "make > > clean" runs in GDB. > > OK, I made the include compulsory. > > > > > > > Finally, I don't know if the change was intentional, but the file was > > previously named Makefile.gnulib.inc and is now named Makefile.gnulib. > > I liked Makefile.gnulib.inc, as it shows it's not a "top-level" > > Makefile, it's meant to be included. > > I just thought 'Makefile.gnulib.inc.in' was a bit much (in the source > tree), but I don't really mind. I changed back to use this filename. > > The patch below has these two fixes. I'll apply in a couple of days > unless anyone objects. I've now pushed this patch. Thanks, Andrew