From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by sourceware.org (Postfix) with ESMTPS id 2CDDD3857C5F for ; Fri, 9 Oct 2020 10:47:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2CDDD3857C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x442.google.com with SMTP id i1so3653718wro.1 for ; Fri, 09 Oct 2020 03:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zGhSTesQ5YAJvT08xTbEDnHLmYDFA9fkuaGtpx8XYwA=; b=B/Ph+QjgZKiEmWnQFKAIoQ0lamlGQfQbc4UZ7Re2EQWVystC27fGN7vtTaw7gSW9wK ml9sgiBSjlnGPCikL4TYl48X/v4UaOoIhGnVWitGdk1Pe5wG6MKpASFLShJ8Ky1eD6FW kKafqpHwozpBdKOJjU6xGqU+1WTm4khD/JVfDpOgE+hmYLpVEmiCifSNqX7U8ml9IW6H mWQV13XAwvqfv5lJbrneDFPCanNNEem3aYBD0MrohEW1vgffmN/PmathEhJqeoiPVk7N G+0Gzjt2GO0w2TkLWTrjPicgKuvJes0emu846cNTfodNDmWSm1l2Ykkb+hA+M0pD/bsD o7dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zGhSTesQ5YAJvT08xTbEDnHLmYDFA9fkuaGtpx8XYwA=; b=G1H2Kn0hIqmLPMz4q72W3ASF4EEzHa96C1IctcPMnxPtUSa/uV70eQxWwUBk+EgjOM DxC2SDbRV2yu+ZyfnIAcYFSnckY7hDJdwGxfEbuYTY2fVMGWldCgbUvsoXYJsY41pml9 JftYVXW8NZGVZuJENW4lS5QoVcP6CFW4KXON7uaTD6FwEqjUVeTpriiinmrjk7AZrXoE 09ZBaf4ZwjqafGQSzncxH3QC/uLDFkTlYrvEQnYFIlFVlmvrG2vvJuUgu2jsD1QKn+gQ 75NIxh/wmnpl/Vne8jRgQY2UXFHtV9MP+18WF0rBx6zvG/z69N55Q9Org1ziIsBrZoEc T5Xw== X-Gm-Message-State: AOAM532aF/A6EB3WNgvpvcfJTJnZS+XeVdWIUPzxJjCkZE677pF5HLnh IeRAb1lJmpwkhJ/AjtTcF9ewQg== X-Google-Smtp-Source: ABdhPJybSAefPbAftwMv3CKtg68LYGK0rHsJiOt6JXPBxktcJ51g1rdpBfgLUbfgBM7QnJpOjn026g== X-Received: by 2002:adf:9f4c:: with SMTP id f12mr2220145wrg.108.1602240449696; Fri, 09 Oct 2020 03:47:29 -0700 (PDT) Received: from localhost (host109-148-134-240.range109-148.btcentralplus.com. [109.148.134.240]) by smtp.gmail.com with ESMTPSA id 88sm12046143wrl.76.2020.10.09.03.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 03:47:29 -0700 (PDT) Date: Fri, 9 Oct 2020 11:47:27 +0100 From: Andrew Burgess To: Shahab Vahedi Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb: Delay releasing target_desc_up in more cases Message-ID: <20201009104727.GQ605036@embecosm.com> References: <20201008092854.GM605036@embecosm.com> <20201008151758.2116169-1-andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.12-100.fc31.x86_64 (x86_64) X-Uptime: 11:46:58 up 6 days, 2:59, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2020 10:47:32 -0000 * Shahab Vahedi [2020-10-08 16:54:31 +0000]: > Hi Andrew, > > With a little bit of an extra change [1], everything works fine. Thank you for > fixing this in ARC port as well. > > > Cheers, > Shahab > > > [1] Changing the "arc_create_traget_description" proto type in the header file > diff --git a/gdb/arch/arc.h b/gdb/arch/arc.h > index 16257596748..1e0e8cd9635 100644 > --- a/gdb/arch/arc.h > +++ b/gdb/arch/arc.h > @@ -70,7 +70,7 @@ struct arc_arch_features > The only external client of this must be the gdbserver which manipulates > the returned data. */ > > -target_desc *arc_create_target_description > +target_desc_up arc_create_target_description > (const struct arc_arch_features &features); > > #else > Thanks. I pushed this patch with your fix applied. Andrew