From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 231523857C4D for ; Mon, 12 Oct 2020 00:49:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 231523857C4D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-330-TXEH-MNWMcCiHrPcVMdBGg-1; Sun, 11 Oct 2020 20:49:13 -0400 X-MC-Unique: TXEH-MNWMcCiHrPcVMdBGg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92101802B46; Mon, 12 Oct 2020 00:49:12 +0000 (UTC) Received: from f32-m1.lan (ovpn-115-29.phx2.redhat.com [10.3.115.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D6136EF4F; Mon, 12 Oct 2020 00:49:12 +0000 (UTC) Date: Sun, 11 Oct 2020 17:49:11 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH v2 0/6] Fix inferior calls from breakpoint condition Message-ID: <20201011174911.76984cec@f32-m1.lan> In-Reply-To: <20201009112719.629-1-natalia.saiapova@intel.com> References: <20200831123519.16232-1-natalia.saiapova () intel ! com> <20201009112719.629-1-natalia.saiapova@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2020 00:49:19 -0000 Hi Natalia, Thank you for rebasing and reposting your work. I've successfully applied your v2 patches to recent GDB sources. I've built GDB with your patches applied and have done some a bit of testing. All looks good so far. I'll do a more thorough review in the coming week. Thanks again, Kevin On Fri, 9 Oct 2020 13:27:12 +0200 Natalia Saiapova via Gdb-patches wrote: > Hi, > > This is the rebased on top of > > 51a948fdf0e gdb: Have allocate_target_description return a unique_ptr > > version of > https://sourceware.org/pipermail/gdb-patches/2020-August/171592.html. > > The patch set is tested on x86_64-pc-linux-gnu configuration, the default > and gdbserver-native boards. > > Regards, > --Natalia > > Natalia Saiapova: > Tankut Baris Aktemur: > > gdb: add in_cond_eval field to thread_control_state struct. > gdb/infrun: in condition evaluation resume only current thread. > gdb/infcall: in condition evaluation register target back after infcall. > gdb/infrun: in condition evaluation wait only for the current inferior. > gdb/infrun: in condition evaluation do not stop all threads. > gdb/testsuite: add tests for inferior calls in breakpoint conditions. > > gdb/breakpoint.c | 3 + > gdb/gdbthread.h | 3 + > gdb/infcall.c | 3 + > gdb/infrun.c | 35 +++++++-- > gdb/testsuite/gdb.threads/infcall-bp-cond.c | 58 +++++++++++++++ > gdb/testsuite/gdb.threads/infcall-bp-cond.exp | 73 +++++++++++++++++++ > 6 files changed, 169 insertions(+), 6 deletions(-) > create mode 100644 gdb/testsuite/gdb.threads/infcall-bp-cond.c > create mode 100644 gdb/testsuite/gdb.threads/infcall-bp-cond.exp > > -- > 2.17.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Gary Kershaw > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 >