From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix testcases with required but unreferenced functions and variables
Date: Mon, 12 Oct 2020 10:36:53 +0100 [thread overview]
Message-ID: <20201012093653.GB7509@blade.nx> (raw)
In-Reply-To: <28b2ddf6-980a-ae35-13b6-1bbda8affe3e@palves.net>
Pedro Alves wrote:
> On 10/7/20 5:39 PM, Gary Benson via Gdb-patches wrote:
> > A number of testcases define variables and/or functions which are
> > referenced by GDB during the test, but which are not referenced from
> > within the test executable. Clang correctly recognizes that these
> > variables and functions are unused, and optimizes them out, causing
> > the testcases in question to fail. This patch adds __attribute__
> > ((used)) in various places to prevent this.
> >
> > Checked on Fedora 32 x86_64, with GCC and Clang. Ok to commit?
>
> OK.
Thanks, I've pushed this now.
Cheers,
Gary
--
Gary Benson - he / him / his
Principal Software Engineer, Red Hat
prev parent reply other threads:[~2020-10-12 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 16:39 Gary Benson
2020-10-09 16:16 ` Pedro Alves
2020-10-12 9:36 ` Gary Benson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012093653.GB7509@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).