From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 20508385802E for ; Mon, 19 Oct 2020 00:53:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 20508385802E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-76-_vcfB9hFMWC4RdZDf-I9wA-1; Sun, 18 Oct 2020 20:53:37 -0400 X-MC-Unique: _vcfB9hFMWC4RdZDf-I9wA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E4F51868403; Mon, 19 Oct 2020 00:53:36 +0000 (UTC) Received: from f32-m1.lan (ovpn-112-216.phx2.redhat.com [10.3.112.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 507731A4D6; Mon, 19 Oct 2020 00:53:36 +0000 (UTC) Date: Sun, 18 Oct 2020 17:53:35 -0700 From: Kevin Buettner To: Natalia Saiapova via Gdb-patches Subject: Re: [PATCH v2 3/6] gdb/infcall: in condition evaluation register target back after infcall. Message-ID: <20201018175335.503910b2@f32-m1.lan> In-Reply-To: <20201009112719.629-4-natalia.saiapova@intel.com> References: <20200831123519.16232-1-natalia.saiapova () intel ! com> <20201009112719.629-1-natalia.saiapova@intel.com> <20201009112719.629-4-natalia.saiapova@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2020 00:53:43 -0000 Hi Natalia, Could you add your commit log comment (or something similar) to your change to infcall.c? Thanks, Kevin On Fri, 9 Oct 2020 13:27:15 +0200 Natalia Saiapova via Gdb-patches wrote: > After an inferior call is finished, the target is unregistered from > the event loop. However, if the inferior call has happened during > the condition evaluation, we still want to get `stop` events from > other threads in `wait_one`. So, register the target back. > > gdb/ChangeLog: > 2020-08-26 Natalia Saiapova > Tankut Baris Aktemur > > * infcall.c (run_inferior_call): In condition evaluation, > register the target back after the infcall. > > Co-authored-by: Natalia Saiapova > Co-authored-by: Tankut Baris Aktemur > > Signed-off-by: Natalia Saiapova > --- > gdb/infcall.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/infcall.c b/gdb/infcall.c > index 399b1724ea2..0b0226f8e82 100644 > --- a/gdb/infcall.c > +++ b/gdb/infcall.c > @@ -667,6 +667,9 @@ run_inferior_call (struct call_thread_fsm *sm, > > call_thread->control.in_infcall = saved_in_infcall; > > + if (call_thread->control.in_cond_eval && target_can_async_p ()) > + target_async (true); > + > return caught_error; > } > > -- > 2.17.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Gary Kershaw > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 >