From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by sourceware.org (Postfix) with ESMTPS id 90A5439874BF for ; Thu, 22 Oct 2020 20:00:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 90A5439874BF Received: by mail-qv1-xf42.google.com with SMTP id b11so1625002qvr.9 for ; Thu, 22 Oct 2020 13:00:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HV6AlILTkggkm3nv2Efi8F9Ix8X8AD8vvZnPcqehkhM=; b=WCu5qAal6rT/JA5QUnzJdI4Sxh7XfOp0BCewDciijKDTQrw2zKtEodE79G2qs0g8qC Gm0UhyXkO146pkUcbBtJ5gRKxfJ7ht2aXiKfe6TOMhR5+QWa9bGuVqHvBk/R7p7HxbaU BUy8Wj7A4jGiQWlI9Os0Ayh+Ds/eRV366IKX+LCxfjmlkh5CnIeYUZmdW3ypZp+mp0In 3QJRlfgWpW/SYVKAQW6zqwqGufjDu7qhc7EAVGAL6HZnNk4h0PLeVD2CHdlgNscKtO+n SZNAm55sOobFiRWt95ewxesYwcXVZSjjhWvgNvcyDZ61AHnjBLgPnbkXHompaDY1LZOI EyLg== X-Gm-Message-State: AOAM530YfJ5wOEYZYSMDOCmZluOiHRU9mbzjGi5YvfYAF6GWjAqtHpFB hC/SUKxVkfkfetsNJDYskOM5WbAD5yfrEQ== X-Google-Smtp-Source: ABdhPJzmh4Rqz1pVuRJzBKTFXuTEkn90AU3xQgex//dKUYaqAKJxjqCFP0NCQe+PI6oPS7elua99Gg== X-Received: by 2002:ad4:45ec:: with SMTP id q12mr4125230qvu.33.1603396833933; Thu, 22 Oct 2020 13:00:33 -0700 (PDT) Received: from localhost.localdomain ([2804:7f0:8284:1487:b9b1:f72a:8f1:600]) by smtp.gmail.com with ESMTPSA id a21sm1711208qkk.98.2020.10.22.13.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2020 13:00:33 -0700 (PDT) From: Luis Machado To: gdb-patches@sourceware.org Cc: alan.hayward@arm.com, jhb@FreeBSD.org, david.spickett@linaro.org Subject: [PATCH v2 04/24] Unit testing for GDB-side remote memory tagging handling Date: Thu, 22 Oct 2020 16:59:54 -0300 Message-Id: <20201022200014.5189-5-luis.machado@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201022200014.5189-1-luis.machado@linaro.org> References: <20201022200014.5189-1-luis.machado@linaro.org> X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2020 20:00:36 -0000 Updated in v2: - Adjusted unit tests to cope with new type field in the remote packets. -- Include some unit testing for the functions handling the new qMemTags and QMemTags packets. gdb/ChangeLog: YYYY-MM-DD Luis Machado * remote: Include gdbsupport/selftest.h. (test_memory_tagging_functions): New function. (_initialize_remote): Register test_memory_tagging_functions. --- gdb/remote.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 89 insertions(+) diff --git a/gdb/remote.c b/gdb/remote.c index fdc7645d47..b57e08659c 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -79,6 +79,7 @@ #include #include #include "async-event.h" +#include "gdbsupport/selftest.h" /* The remote target. */ @@ -14527,6 +14528,89 @@ remote_target::store_memtags (CORE_ADDR address, size_t len, return 0; } +#if GDB_SELF_TEST + +namespace selftests { + +static void +test_memory_tagging_functions (void) +{ + remote_target remote; + + struct packet_config *config + = &remote_protocol_packets[PACKET_memory_tagging_feature]; + + /* Test memory tagging packet support. */ + config->support = PACKET_SUPPORT_UNKNOWN; + SELF_CHECK (remote.supports_memory_tagging () == false); + config->support = PACKET_DISABLE; + SELF_CHECK (remote.supports_memory_tagging () == false); + config->support = PACKET_ENABLE; + SELF_CHECK (remote.supports_memory_tagging () == true); + + /* Setup testing. */ + gdb::char_vector packet; + gdb::byte_vector tags, bv; + std::string expected, reply; + packet.resize (32000); + + /* Test creating a qMemTags request. */ + + expected = "qMemTags:0,0:0"; + create_fmemtags_request (packet, 0x0, 0x0, 0); + SELF_CHECK (strcmp (packet.data (), expected.c_str ()) == 0); + + expected = "qMemTags:deadbeef,10:1"; + create_fmemtags_request (packet, 0xdeadbeef, 16, 1); + SELF_CHECK (strcmp (packet.data (), expected.c_str ()) == 0); + + /* Test parsing a qMemTags reply. */ + + /* Error reply, tags vector unmodified. */ + reply = "E00"; + strcpy (packet.data (), reply.c_str ()); + tags.resize (0); + SELF_CHECK (parse_fmemtags_reply (packet, tags) != 0); + SELF_CHECK (tags.size () == 0); + + /* Valid reply, tags vector updated. */ + tags.resize (0); + bv.resize (0); + + for (int i = 0; i < 5; i++) + bv.push_back (i); + + reply = "m" + bin2hex (bv.data (), bv.size ()); + strcpy (packet.data (), reply.c_str ()); + + SELF_CHECK (parse_fmemtags_reply (packet, tags) == 0); + SELF_CHECK (tags.size () == 5); + + for (int i = 0; i < 5; i++) + SELF_CHECK (tags[i] == i); + + /* Test creating a QMemTags request. */ + + /* Empty tag data. */ + tags.resize (0); + expected = "QMemTags:0,0:0:"; + create_smemtags_request (packet, 0x0, 0x0, 0, tags); + SELF_CHECK (memcmp (packet.data (), expected.c_str (), + expected.length ()) == 0); + + /* Non-empty tag data. */ + tags.resize (0); + for (int i = 0; i < 5; i++) + tags.push_back (i); + expected = "QMemTags:deadbeef,ff:1:0001020304"; + create_smemtags_request (packet, 0xdeadbeef, 255, 1, tags); + SELF_CHECK (memcmp (packet.data (), expected.c_str (), + expected.length ()) == 0); +} + +} // namespace selftests +#endif /* GDB_SELF_TEST */ + void _initialize_remote (); void _initialize_remote () @@ -15040,4 +15124,9 @@ Specify \"unlimited\" to display all the characters."), /* Eventually initialize fileio. See fileio.c */ initialize_remote_fileio (&remote_set_cmdlist, &remote_show_cmdlist); + +#if GDB_SELF_TEST + selftests::register_test ("remote_memory_tagging", + selftests::test_memory_tagging_functions); +#endif } -- 2.17.1