From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.250]) by sourceware.org (Postfix) with ESMTPS id E675D384243E for ; Sat, 24 Oct 2020 21:09:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E675D384243E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 9A0A9400C63A6 for ; Sat, 24 Oct 2020 16:09:00 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id WQmak8VixBD8bWQmak2ex1; Sat, 24 Oct 2020 16:09:00 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=y+RhrYGS/AF8cvQosy4oiv1ygS5D9cj31XJS/soTm5U=; b=RUeV5UYNe/r/gt9Dr7ZsKplLZB iIVtIVVld+Pb0RwYu8tlQCkBTm2eH+XKKEKjsVnkV54EK+NreLjKrMUTkRdrdX+nrArKSNdztzfhh 3V6TQ9GWHE0f56zmSsRZ4kUqq; Received: from 174-16-123-164.hlrn.qwest.net ([174.16.123.164]:36770 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kWQma-003Xst-Dj; Sat, 24 Oct 2020 15:09:00 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 10/11] Use gdbpy_ref in instantiate_pretty_printer Date: Sat, 24 Oct 2020 15:08:55 -0600 Message-Id: <20201024210856.12021-11-tom@tromey.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20201024210856.12021-1-tom@tromey.com> References: <20201024210856.12021-1-tom@tromey.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.123.164 X-Source-L: No X-Exim-ID: 1kWQma-003Xst-Dj X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-123-164.hlrn.qwest.net (bapiya.Home) [174.16.123.164]:36770 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3033.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2020 21:09:02 -0000 This changes instantiate_pretty_printer to use gdbpy_ref, removing a call to Py_DECREF. gdb/ChangeLog 2020-10-24 Tom Tromey * varobj.c (instantiate_pretty_printer): Use gdbpy_ref. --- gdb/ChangeLog | 4 ++++ gdb/varobj.c | 11 +++-------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/gdb/varobj.c b/gdb/varobj.c index 8b02eb338b4..be161eb0208 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -459,16 +459,11 @@ varobj_delete (struct varobj *var, bool only_children) static PyObject * instantiate_pretty_printer (PyObject *constructor, struct value *value) { - PyObject *val_obj = NULL; - PyObject *printer; - - val_obj = value_to_value_object (value); - if (! val_obj) + gdbpy_ref<> val_obj (value_to_value_object (value)); + if (val_obj == nullptr) return NULL; - printer = PyObject_CallFunctionObjArgs (constructor, val_obj, NULL); - Py_DECREF (val_obj); - return printer; + return PyObject_CallFunctionObjArgs (constructor, val_obj.get (), NULL); } #endif -- 2.17.2