From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.187]) by sourceware.org (Postfix) with ESMTPS id E323D3851C0D for ; Sat, 24 Oct 2020 21:08:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E323D3851C0D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 826B3B1AD for ; Sat, 24 Oct 2020 16:08:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id WQmZk7WpNXp2AWQmZkqu7o; Sat, 24 Oct 2020 16:08:59 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FvjOlUHyGPd/7kHPrVAY2lD3Pi+UaMTMVMv8JKYzIF0=; b=jwbLn9LJapzbWBTJuFdeoj/3Os 1qXnbin/Afju8qSiB2EiDSL37bhdLlMmbZWxlnXPoMSLkq/sh+f4UDHhjobQ6K6+ToMScCFZ69Rzx 7D4bk/EqEPXJ1KoZvpewlO9ow; Received: from 174-16-123-164.hlrn.qwest.net ([174.16.123.164]:36770 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kWQmZ-003Xst-B9; Sat, 24 Oct 2020 15:08:59 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 04/11] C++-ify varobj iteration Date: Sat, 24 Oct 2020 15:08:49 -0600 Message-Id: <20201024210856.12021-5-tom@tromey.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20201024210856.12021-1-tom@tromey.com> References: <20201024210856.12021-1-tom@tromey.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.123.164 X-Source-L: No X-Exim-ID: 1kWQmZ-003Xst-B9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-123-164.hlrn.qwest.net (bapiya.Home) [174.16.123.164]:36770 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3033.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2020 21:09:01 -0000 This changes the varobj iteration code to use a C++ class rather than a C struct with a separate "ops" structure. The only implementation is updated to use inheritance. This simplifies the code quite nicely. gdb/ChangeLog 2020-10-24 Tom Tromey * varobj.c (update_dynamic_varobj_children, install_visualizer) (varobj::~varobj): Update. * varobj-iter.h (struct varobj_iter): Change to interface class. (struct varobj_iter_ops): Remove. (varobj_iter_next, varobj_iter_delete): Remove. * python/py-varobj.c (struct py_varobj_iter): Derive from varobj_iter. Add constructor, destructor. Rename members. (py_varobj_iter::~py_varobj_iter): Rename from py_varobj_iter_dtor. (py_varobj_iter::next): Rename from py_varobj_iter_next. (py_varobj_iter_ops): Remove. (py_varobj_iter): Rename from py_varobj_iter_ctor. (py_varobj_iter_new): Remove. (py_varobj_get_iterator): Update. --- gdb/ChangeLog | 17 +++++++++ gdb/python/py-varobj.c | 80 +++++++++++++++--------------------------- gdb/varobj-iter.h | 41 ++-------------------- gdb/varobj.c | 10 +++--- 4 files changed, 54 insertions(+), 94 deletions(-) diff --git a/gdb/python/py-varobj.c b/gdb/python/py-varobj.c index 9c791f64df1..df6f9c5a953 100644 --- a/gdb/python/py-varobj.c +++ b/gdb/python/py-varobj.c @@ -21,34 +21,43 @@ /* A dynamic varobj iterator "class" for python pretty-printed varobjs. This inherits struct varobj_iter. */ -struct py_varobj_iter +struct py_varobj_iter : public varobj_iter { - /* The 'base class'. */ - struct varobj_iter base; + py_varobj_iter (struct varobj *var, gdbpy_ref<> &&pyiter); + ~py_varobj_iter () override; + + varobj_item *next () override; + +private: + + /* The varobj this iterator is listing children for. */ + struct varobj *m_var; + + /* The next raw index we will try to check is available. If it is + equal to number_of_children, then we've already iterated the + whole set. */ + int m_next_raw_index = 0; /* The python iterator returned by the printer's 'children' method, or NULL if not available. */ - PyObject *iter; + PyObject *m_iter; }; /* Implementation of the 'dtor' method of pretty-printed varobj iterators. */ -static void -py_varobj_iter_dtor (struct varobj_iter *self) +py_varobj_iter::~py_varobj_iter () { - struct py_varobj_iter *dis = (struct py_varobj_iter *) self; - gdbpy_enter_varobj enter_py (self->var); - Py_XDECREF (dis->iter); + gdbpy_enter_varobj enter_py (m_var); + Py_XDECREF (m_iter); } /* Implementation of the 'next' method of pretty-printed varobj iterators. */ -static varobj_item * -py_varobj_iter_next (struct varobj_iter *self) +varobj_item * +py_varobj_iter::next () { - struct py_varobj_iter *t = (struct py_varobj_iter *) self; PyObject *py_v; varobj_item *vitem; const char *name = NULL; @@ -56,9 +65,9 @@ py_varobj_iter_next (struct varobj_iter *self) if (!gdb_python_initialized) return NULL; - gdbpy_enter_varobj enter_py (self->var); + gdbpy_enter_varobj enter_py (m_var); - gdbpy_ref<> item (PyIter_Next (t->iter)); + gdbpy_ref<> item (PyIter_Next (m_iter)); if (item == NULL) { @@ -78,7 +87,7 @@ py_varobj_iter_next (struct varobj_iter *self) } std::string name_str = string_printf ("", - self->next_raw_index++); + m_next_raw_index++); item.reset (Py_BuildValue ("(ss)", name_str.c_str (), value_str.get ())); if (item == NULL) @@ -107,45 +116,18 @@ py_varobj_iter_next (struct varobj_iter *self) gdbpy_print_stack (); vitem->name = name; - self->next_raw_index++; + m_next_raw_index++; return vitem; } -/* The 'vtable' of pretty-printed python varobj iterators. */ - -static const struct varobj_iter_ops py_varobj_iter_ops = -{ - py_varobj_iter_dtor, - py_varobj_iter_next -}; - /* Constructor of pretty-printed varobj iterators. VAR is the varobj whose children the iterator will be iterating over. PYITER is the python iterator actually responsible for the iteration. */ -static void -py_varobj_iter_ctor (struct py_varobj_iter *self, - struct varobj *var, gdbpy_ref<> &&pyiter) +py_varobj_iter::py_varobj_iter (struct varobj *var, gdbpy_ref<> &&pyiter) + : m_var (var), + m_iter (pyiter.release ()) { - self->base.var = var; - self->base.ops = &py_varobj_iter_ops; - self->base.next_raw_index = 0; - self->iter = pyiter.release (); -} - -/* Allocate and construct a pretty-printed varobj iterator. VAR is - the varobj whose children the iterator will be iterating over. - PYITER is the python iterator actually responsible for the - iteration. */ - -static struct py_varobj_iter * -py_varobj_iter_new (struct varobj *var, gdbpy_ref<> &&pyiter) -{ - struct py_varobj_iter *self; - - self = XNEW (struct py_varobj_iter); - py_varobj_iter_ctor (self, var, std::move (pyiter)); - return self; } /* Return a new pretty-printed varobj iterator suitable to iterate @@ -154,8 +136,6 @@ py_varobj_iter_new (struct varobj *var, gdbpy_ref<> &&pyiter) struct varobj_iter * py_varobj_get_iterator (struct varobj *var, PyObject *printer) { - struct py_varobj_iter *py_iter; - gdbpy_enter_varobj enter_py (var); if (!PyObject_HasAttr (printer, gdbpy_children_cst)) @@ -176,7 +156,5 @@ py_varobj_get_iterator (struct varobj *var, PyObject *printer) error (_("Could not get children iterator")); } - py_iter = py_varobj_iter_new (var, std::move (iter)); - - return &py_iter->base; + return new py_varobj_iter (var, std::move (iter)); } diff --git a/gdb/varobj-iter.h b/gdb/varobj-iter.h index 240b686b256..ed654190ca5 100644 --- a/gdb/varobj-iter.h +++ b/gdb/varobj-iter.h @@ -28,50 +28,15 @@ struct varobj_item struct value *value; }; -struct varobj_iter_ops; - /* A dynamic varobj iterator "class". */ struct varobj_iter { - /* The 'vtable'. */ - const struct varobj_iter_ops *ops; - - /* The varobj this iterator is listing children for. */ - struct varobj *var; - - /* The next raw index we will try to check is available. If it is - equal to number_of_children, then we've already iterated the - whole set. */ - int next_raw_index; -}; - -/* The vtable of the varobj iterator class. */ +public: -struct varobj_iter_ops -{ - /* Destructor. Releases everything from SELF (but not SELF - itself). */ - void (*dtor) (struct varobj_iter *self); + virtual ~varobj_iter () = default; - /* Returns the next object or NULL if it has reached the end. */ - varobj_item *(*next) (struct varobj_iter *self); + virtual varobj_item *next () = 0; }; -/* Returns the next varobj or NULL if it has reached the end. */ - -#define varobj_iter_next(ITER) (ITER)->ops->next (ITER) - -/* Delete a varobj_iter object. */ - -#define varobj_iter_delete(ITER) \ - do \ - { \ - if ((ITER) != NULL) \ - { \ - (ITER)->ops->dtor (ITER); \ - xfree (ITER); \ - } \ - } while (0) - #endif /* VAROBJ_ITER_H */ diff --git a/gdb/varobj.c b/gdb/varobj.c index ce5c85f163b..edcaad417f6 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -702,7 +702,7 @@ update_dynamic_varobj_children (struct varobj *var, if (update_children || var->dynamic->child_iter == NULL) { - varobj_iter_delete (var->dynamic->child_iter); + delete var->dynamic->child_iter; var->dynamic->child_iter = varobj_get_iterator (var); varobj_clear_saved_item (var->dynamic); @@ -729,7 +729,7 @@ update_dynamic_varobj_children (struct varobj *var, } else { - item = varobj_iter_next (var->dynamic->child_iter); + item = var->dynamic->child_iter->next (); /* Release vitem->value so its lifetime is not bound to the execution of a command. */ if (item != NULL && item->value != NULL) @@ -739,7 +739,7 @@ update_dynamic_varobj_children (struct varobj *var, if (item == NULL) { /* Iteration is done. Remove iterator from VAR. */ - varobj_iter_delete (var->dynamic->child_iter); + delete var->dynamic->child_iter; var->dynamic->child_iter = NULL; break; } @@ -1070,7 +1070,7 @@ install_visualizer (struct varobj_dynamic *var, PyObject *constructor, Py_XDECREF (var->pretty_printer); var->pretty_printer = visualizer; - varobj_iter_delete (var->child_iter); + delete var->child_iter; var->child_iter = NULL; } @@ -1881,7 +1881,7 @@ varobj::~varobj () } #endif - varobj_iter_delete (var->dynamic->child_iter); + delete var->dynamic->child_iter; varobj_clear_saved_item (var->dynamic); if (is_root_p (var)) -- 2.17.2