From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by sourceware.org (Postfix) with ESMTPS id 2F8D63972030 for ; Wed, 28 Oct 2020 15:29:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2F8D63972030 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x342.google.com with SMTP id l8so3514808wmg.3 for ; Wed, 28 Oct 2020 08:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Io+8nqm1DTanwBq+yzVxQjf6nX/+a2V5ufxZ+SKfCGk=; b=FgUWPY39jO6f9AIMM2jOvSnHT6ymLEK8HYgu0pUWaV0Fpt4vHh6FXvT8emSRWk5N1c c9Faq6wSgw0SPhEEBcoKldttX27h0POgmdV3fWPby3sKQSNBPcHoMFxEM/fs46GlOTXv 6xxJC4xBU52i4rZsoQQqcGGnsXRCEuxM25spwMWXfIK9844kwYGQyhcOBrkNwgU5+viX r+YfCbNTfIclOjSd5OTOSwnihubJZ6qXTimxgHc4b3wafo4mV7Z+b5hrlQ1CS30V+B6Z a2IwlhdyGmpSidJoXH+K/OdEUTNXAx+LeEdLZOMHar+ibAZIyCFtxwapLj3TT1nBTexC m9Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Io+8nqm1DTanwBq+yzVxQjf6nX/+a2V5ufxZ+SKfCGk=; b=pWVm7wTF7uwUQJ6HQuvfKXoruqLqfkYyYI45PP24Y/fUlMo53SC9IsF+spGejhMi6d qCMYFpgAYsYnHdYP/1DPzV2aTRTX518NsCOI9AMdl7R7c1DNymVfyXrgIJCwe715HdWx AsU8WLIUkhPYxpIUMqZtnCNBRjeRxw+8Cj+M9EKySTHH78uu24vVAeEYmNJZFIBoWkuc e3c2cB+3KKhrZh+gDkI1SYwBY3hZr4xniVElLx+sStxjKidy5IHhmUwmkB4J1iVAawap a8N2i6OZdX1ks6pKtABWEGdRnNQA8wbVztJCSSP5dZcasxEGMEezSAIk7SnuTCRyMhGc BBuw== X-Gm-Message-State: AOAM532TQnvtBnn7dG+jlKj3RclcC47bdvFuWa047VX7yfxpR6HFoJ8T kPfmIGXt0tr2ZhCH13j8HnpGItPM0KS27Q== X-Google-Smtp-Source: ABdhPJzJXYvweBtOCYoV/2gcbSJe858lYScBegF0E04BWB7M4EjQslTST1zmUiA32/YkZ5Fdh2/ogA== X-Received: by 2002:a1c:b757:: with SMTP id h84mr8625595wmf.108.1603898975095; Wed, 28 Oct 2020 08:29:35 -0700 (PDT) Received: from localhost (host109-154-163-49.range109-154.btcentralplus.com. [109.154.163.49]) by smtp.gmail.com with ESMTPSA id u15sm7676177wrm.77.2020.10.28.08.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 08:29:33 -0700 (PDT) Date: Wed, 28 Oct 2020 15:29:32 +0000 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Adding startup files to GDB Message-ID: <20201028152932.GA2729@embecosm.com> References: <87blgu13v4.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87blgu13v4.fsf@tromey.com> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 15:18:40 up 3 days, 6:21, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2020 15:29:37 -0000 * Tom Tromey [2020-10-22 13:02:07 -0600]: > Andrew> Patch #4 adds the startup file support. Compared to Tom's original work: > Andrew> (a) there's no auto saving of startup options, > > Andrew> (b) there's command line flag support for passing startup options > Andrew> to GDB. > > Andrew> (c) there's support for a home directory and current working > Andrew> directory startup file (only because this is basically free > Andrew> given the restructuring of the code). > > Andrew> Patch #5 adds back the auto-save feature from Tom's series, however, I > Andrew> have this off by default. I (personally) dislike the auto-save > Andrew> feature, though I can see why some users might want it. I hope the > Andrew> proposal I have here is might be a good middle ground. > > Could you say why you dislike it? Sure. I just have a general dislike of tools that auto-write config files. I prefer to be able to modify these files myself. I guess the counter position is that a user should never be touching these files by hand, they should be considered more of an internal cache. Another area where auto-saving might cause problems might be if a user runs multiple versions of GDB (e.g. a desktop version, and several different versions built to debug different remote targets), if these versions have different sets of features that they auto-save then a user will end up "loosing" settings in some cases I think. > > The reason I did it the way I did is that I thought it was strange to > have a command like "set startup-blah-blah off" that would be useless to > use in a running gdb. It seemed to me that the name & intended use of > the command implied auto-saving. Understood. > > Regardless of the choice here, I don't think it makes sense to have > another option to control whether the first options are auto-saved. > This is "feature to enable a feature" territory for me. I don't really understand what "feature to enable a feature" means. Does this mean you don't see any way that having a flag to control auto-saving could be acceptable? What if it was just simple that I proposed here, say 'set auto-save-startup-options on|off', which could then be placed in to the startup file to disable auto-save? Thanks, Andrew