From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by sourceware.org (Postfix) with ESMTPS id 62C643857C4D for ; Mon, 2 Nov 2020 10:20:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 62C643857C4D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x441.google.com with SMTP id n15so13936524wrq.2 for ; Mon, 02 Nov 2020 02:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JbslWprsNzFhgYPxYZWooFBtdyAsOsnqn2u6XnIJZr8=; b=USOmiapMzgFECtTZdeBFSkClxSovG4GaQrjL4s5U3v7ssh+iH7TeZJNXtFlf9qU3EV pECt8c5bXpNhGmJ1rUcxtQRDRQP1gCrc1eNIV2Tj5gBjY6T/j1Z6yarom3viOuyhlmjj wz68hd0s3CAkpt/K/7OvY8nrP4cc0bkx7JappsgLwFMCxGT2aePIk8UR129OXAVAQcbd x+tRJc8tvyU0jU7qEkIOPAlpjN5yu4XU/4q3m+rN0B4iBf/WO+ai7Tb5kakZFv6KJefP vnmg8ZHGSQMS1aeTCMJ8N1xIzOFyLJWR5sEJbBBp4PqEFBaMc0+N3xGTNXTqUrgJWwA1 AXiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JbslWprsNzFhgYPxYZWooFBtdyAsOsnqn2u6XnIJZr8=; b=OkEnexpfpoKW4wNoubEebdEg7AplFE0CLhmNt6Hir/LoMR4Moom5fjOaT94HVa3GSF RQCJu7cgo9LkR8VqYJSNwMLZZ54KZTFnnTMu46nsrr7KVRRQFWCH0Rk2d8BAonV39r94 TZtSxvxcgNzoQQ8F920/cZsaZLykKMkozsnViabyiq1lX0THbrUdgwneaj5oz/nPNBx/ Gv1P+SjBvZFzIWzkab9vydXypoW61/INSPbhmq9bLlbUg5poPrJ+E0wCCvceEvSp66Kf I2po+O5F2PhIHLR1ewNZgO/OUSUVnItmWibauiwY+Bo0/gFn1hvIen48t5daaZc73tIm pY+g== X-Gm-Message-State: AOAM532a2EgyQTyBQgaxSZtBAHf38PTMOPf91+4ybkdOChRQhomMfCPw FqeynNCEP2eO8M5BoPAoOyXDig== X-Google-Smtp-Source: ABdhPJznSEqq5ccSQdeTi1U2HyDFyKv7uMK+a16b1B5RImaMIZ9sv9wHB056XJvKGtpVsB1AYUbybw== X-Received: by 2002:a5d:424a:: with SMTP id s10mr19348661wrr.130.1604312422518; Mon, 02 Nov 2020 02:20:22 -0800 (PST) Received: from localhost (host109-154-163-49.range109-154.btcentralplus.com. [109.154.163.49]) by smtp.gmail.com with ESMTPSA id 30sm21500511wrs.84.2020.11.02.02.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 02:20:21 -0800 (PST) Date: Mon, 2 Nov 2020 10:20:20 +0000 From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org, tom@tromey.com Subject: Re: [PATCH 2/7] gdb: use get_standard_config_dir when looking for .gdbinit Message-ID: <20201102102020.GF2729@embecosm.com> References: <92f3b4d4a87643bbb9768fbcb9ee8c77cd5ba8de.1601927355.git.andrew.burgess@embecosm.com> <83eem98b1d.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83eem98b1d.fsf@gnu.org> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 10:17:27 up 8 days, 1:20, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2020 10:20:24 -0000 * Eli Zaretskii [2020-10-08 09:52:14 +0300]: > > From: Andrew Burgess > > Date: Wed, 7 Oct 2020 21:05:06 +0100 > > Cc: Tom Tromey > > > > This commit effectively changes the default location of the .gdbinit > > file, while maintaining backward compatibility. > > > > For non Apple hosts the .gdbinit file will now be looked for in the > > following locations: > > > > $XDG_CONFIG_HOME/gdb/gdbinit > > $HOME/.config/gdb/gdbinit > > $HOME/.gdbinit > > > > On Apple hosts the search order is instead: > > > > $HOME/Library/Preferences/gdb/gdbinit > > $HOME/.gdbinit > > Thanks. > > I still wonder why we treat Apple specially here. > > > +Do not execute commands found in any initialization file > > "files" > > Also, I think this should say "in any startup or initialization > files", as startup file loading is also prevented, right? > > > +(@pxref{Initialization Files}). > > There should be a cross-reference to where startup files are described > as well. Eli, Thanks for the review. I'm going to push the first 3 patches in this series as they have had positive feedback, and can be considered separate from the other 4 patches. As these first 3 don't introduce startup files (they were just setup for that) then I'll not make the startup file related changes you suggest here, instead I'll make these changes in the later patches as I rebase them. The other fixes you have suggested I have of course made. Thanks, Andrew > > > +As the system wide and home directory initialization files are > > +@value{GDBN} will check the current directory for a file called > > +@file{./.gdbinit}. It is loaded last, after command line options > ^^^^^^^^^^ > The "./" part is redundant here.