From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id E351D3857C65 for ; Sun, 15 Nov 2020 05:30:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E351D3857C65 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4F31056046; Sun, 15 Nov 2020 00:30:59 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aXeN7+Cs+AA6; Sun, 15 Nov 2020 00:30:59 -0500 (EST) Received: from float.home (localhost.localdomain [127.0.0.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id EFFFF56044; Sun, 15 Nov 2020 00:30:58 -0500 (EST) Received: by float.home (Postfix, from userid 1000) id 6B647A1870; Sun, 15 Nov 2020 09:30:53 +0400 (+04) Date: Sun, 15 Nov 2020 09:30:53 +0400 From: Joel Brobecker To: Simon Marchi Cc: GDB patches Subject: Re: [PATCH 5/9] Add support for printing value of DWARF-based fixed-point type objects Message-ID: <20201115053053.GC404828@adacore.com> References: <1604817017-25807-1-git-send-email-brobecker@adacore.com> <1604817017-25807-6-git-send-email-brobecker@adacore.com> <2d12525a-3a85-3f69-bfea-22166f7fd358@simark.ca> <20201114113005.GB404828@adacore.com> <108c1483-683b-f98d-c424-27871993667c@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <108c1483-683b-f98d-c424-27871993667c@simark.ca> X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Nov 2020 05:31:01 -0000 > On 2020-11-14 6:30 a.m., Joel Brobecker wrote: > > Can you tell me if the attached patch corresponds to what you had > > in mind? As the revlog suggests, it's missing a bit of doc around it, > > but I wanted to make sure I did this correctly before adding the forms. > > Yes, that looks fine, thanks. Thanks for the pre-review, Simon, and confirming I was on the right track. > I would split the following assert in two: > > gdb_assert (this->code () == TYPE_CODE_FIXED_POINT > && this->main_type->type_specific.fixed_point_info != nullptr); > > because if it fails, it makes it easier at first glance to know which > condition was false. Indeed. That's a good idea. > Otherwise, that is fine with me. I think the whole type-specific stuff > management will have to be redesigned at some point anyway, so that we > can use non-POD types in there. Agreed. One even bigger dream of mine was to have our struct type become a hierarchy of classes, rather than just one. Then the type-specific stuff gets taken care of via class extension... -- Joel