From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id A35D73857C65 for ; Sun, 15 Nov 2020 07:09:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A35D73857C65 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7A4425604C; Sun, 15 Nov 2020 02:09:05 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OOib61BrYaiT; Sun, 15 Nov 2020 02:09:05 -0500 (EST) Received: from float.home (localhost.localdomain [127.0.0.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 1AECA56049; Sun, 15 Nov 2020 02:09:05 -0500 (EST) Received: by float.home (Postfix, from userid 1000) id 28E6BA1870; Sun, 15 Nov 2020 11:09:00 +0400 (+04) Date: Sun, 15 Nov 2020 11:09:00 +0400 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 7/9] Add ptype support for DWARF-based fixed-point types Message-ID: <20201115070900.GF404828@adacore.com> References: <1604817017-25807-1-git-send-email-brobecker@adacore.com> <1604817017-25807-8-git-send-email-brobecker@adacore.com> <360aa942-16f6-b81d-720e-9d5897f73135@simark.ca> <20201115065749.GE404828@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201115065749.GE404828@adacore.com> X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Nov 2020 07:09:06 -0000 > > > + gdb_test_no_output "set language $lang" \ > > > + "set language to $lang for ptype test" > > > + > > > + gdb_test "ptype pck__fp1_var" $fp1_re > > > + > > > + gdb_test "ptype pck__fp2_var" $fp2_re > > > + > > > + gdb_test "ptype pck__fp3_var" $fp3_re > > > + > > > + if { $lang == "modula-2" || $lang == "pascal" } { > > > + setup_xfail "*-*-*" "not supported by language" > > > + } > > > > Can you give more details about this? What prevents these languages > > from printing ? I'm confused, because as far as I can tell > > C doesn't support range types more than these two languages, and it's > > able to print . > > Both trigger the following error: > > (gdb) ptype pck__fp1_range_var > type = [Invalid type code in symbol table. > > It didn't seem to be worth the effort of going any further than that, > because I didn't didn't think either language would have fixed point > types. I should probably expand a bit: I tried to make the implementation of this feature as generic as possible, so that all current and future languages that provide support for these kinds of types can benefit from it with as little work as possible. For some reason, this doesn't work for M2 and Pascal, and the decision I made at the time was to ignore these issues on the basis that these are errors a real user is unlikely to hit. -- Joel