From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 79180385800A for ; Thu, 31 Dec 2020 15:51:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 79180385800A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x335.google.com with SMTP id 190so7572781wmz.0 for ; Thu, 31 Dec 2020 07:51:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=NHuH0DNIKN47DGxktE76U+VjEaBX2/cJMoCbOE9rcVA=; b=dO1cxaf5MKknL7dPSjmYbRU0rGwqCuSG7By4Pd3SlWxS9z0mbK/oeDm0gs+mPT5RUv nBQOEqZSc+b4A8fX9FPoBLGamQ3c6JNWf5D6QYnlMbqiLkS6nKyVAHQDcUrrl5iSxhQd 3aG+nhEDupZqjmO3Ygv4JfZV7zfs9hWfkPMBcat3GYUwWzgYBn0sL667tV84U2271H3B zfj37QLkoTV6rcXCeV9r5zWgi1GGXYzkEzVN6Fg7G5yNG11bEoWxmJc0s82v/1L2k9b9 KUyu+PIagH+VNMovVRN89Sx9ilNspJnxmovp5+VXd80wWUOj9xzUAHrnxfz5Sfsk2Udq LbdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=NHuH0DNIKN47DGxktE76U+VjEaBX2/cJMoCbOE9rcVA=; b=ufNVNwZDhCCyP2B9L+/9lld80P3RyR4hNHYR04CfnbZAJrL7sbGKDzMut0OIkLDLDA bLsP3sG6+d58ArinGX+0grs0+FmcqP7gtS9mDBLDqOZizbcduEIh6q0ftcu6yVeyhwbl c/0UcE4TiZrh9A52iOx2ZyNLs0ZodVwT2mI9qbI/buIU2wZ/GNPwxaqRzsLqZr1mzOkw w8yGF9XGiM2QwER0fPcSih2orEZzw1P5klzgSuA6MRGD8ruxI/KUyX29FmF4o6TW4emH IlFQ/4xEjvvDxjr8q2Pc1LRMiysSpqBZIGjjRLNiRpJ5gwuB7M77tOEH8+uxcHm57pSC MQew== X-Gm-Message-State: AOAM532rMku+93WLvkqTwopZNrID9bO7+u/nJKwIPZ5B84gzq7Kunwb7 eIPjcIkVO3XTc6k1eNvJJR0r27m+EGkudQ== X-Google-Smtp-Source: ABdhPJwWK2Dd4F8Sw5lQO4LUzYL0IGTw1Lat1n36BQoUaTZHkn1CumTaNmXm+B7slVji0RvbGNh0Nw== X-Received: by 2002:a1c:741a:: with SMTP id p26mr12808429wmc.47.1609429874587; Thu, 31 Dec 2020 07:51:14 -0800 (PST) Received: from localhost (host109-154-20-128.range109-154.btcentralplus.com. [109.154.20.128]) by smtp.gmail.com with ESMTPSA id k18sm77087063wrd.45.2020.12.31.07.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Dec 2020 07:51:13 -0800 (PST) Date: Thu, 31 Dec 2020 15:51:12 +0000 From: Andrew Burgess To: Lancelot SIX Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] typeprint.h: reorder struct declaration Message-ID: <20201231155112.GS2945@embecosm.com> References: <20201231125324.14779-1-lsix@lancelotsix.com> <20201231125324.14779-2-lsix@lancelotsix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 15:45:10 up 22 days, 20:29, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Dec 2020 15:51:17 -0000 * Lancelot SIX via Gdb-patches [2020-12-31 13:= 01:26 +0000]: > Hi >=20 > On 31/12/2020 12:53, Lancelot SIX via Gdb-patches wrote: > > Move the declaration of struct type_print_raw_options before struct > > print_offset_data to ease upcoming changes. This is a helper commit > > intended to make it easier to build a print_offset_data object from > > configurations given by a type_print_raw_options. > >=20 > > gdb/ChangeLog: > >=20 > > * typeprint.h (struct type_print_options): move before > > print_offsetdata >=20 > Just realized I had formatting issues here. I=E2=80=99ll change that ASAP= , with > other elements that might come with reviews. Good spot :) Just to ensure we're in sync, there's a white space issue on line #2, and you should capitalise 'Move', and end with a full stop. >=20 > When doing such modification, do I re-send the entire patches series or j= ust > the one affected? (I am not yet familiar with working with mailing-list > based workflows). When it is just one patch changing independent of the others, and if the changes are not huge (so minor clean ups), I would normally just reply to the original patch with a new version. When I've revised multiple patches, or if I make large changes to a patch, I'll post the whole series again with a v2, v3, etc added. Otherwise, this first patch looks fine. Thanks, Andrew >=20 > BR >=20 > Lancelot >=20 > > --- > > gdb/typeprint.h | 60 ++++++++++++++++++++++++------------------------- > > 1 file changed, 30 insertions(+), 30 deletions(-) > >=20 > > diff --git a/gdb/typeprint.h b/gdb/typeprint.h > > index d595cbe208..b75fa4d9f2 100644 > > --- a/gdb/typeprint.h > > +++ b/gdb/typeprint.h > > @@ -26,6 +26,36 @@ struct ui_file; > > struct typedef_hash_table; > > struct ext_lang_type_printers; > > +struct type_print_options > > +{ > > + /* True means that no special printing flags should apply. */ > > + unsigned int raw : 1; > > + > > + /* True means print methods in a class. */ > > + unsigned int print_methods : 1; > > + > > + /* True means print typedefs in a class. */ > > + unsigned int print_typedefs : 1; > > + > > + /* True means to print offsets, a la 'pahole'. */ > > + unsigned int print_offsets : 1; > > + > > + /* The number of nested type definitions to print. -1 =3D=3D all. = */ > > + int print_nested_type_limit; > > + > > + /* If not NULL, a local typedef hash table used when printing a > > + type. */ > > + typedef_hash_table *local_typedefs; > > + > > + /* If not NULL, a global typedef hash table used when printing a > > + type. */ > > + typedef_hash_table *global_typedefs; > > + > > + /* The list of type printers associated with the global typedef > > + table. This is intentionally opaque. */ > > + struct ext_lang_type_printers *global_printers; > > +}; > > + > > struct print_offset_data > > { > > /* The offset to be applied to bitpos when PRINT_OFFSETS is true. > > @@ -73,36 +103,6 @@ struct print_offset_data > > const char *for_what); > > }; > > -struct type_print_options > > -{ > > - /* True means that no special printing flags should apply. */ > > - unsigned int raw : 1; > > - > > - /* True means print methods in a class. */ > > - unsigned int print_methods : 1; > > - > > - /* True means print typedefs in a class. */ > > - unsigned int print_typedefs : 1; > > - > > - /* True means to print offsets, a la 'pahole'. */ > > - unsigned int print_offsets : 1; > > - > > - /* The number of nested type definitions to print. -1 =3D=3D all. = */ > > - int print_nested_type_limit; > > - > > - /* If not NULL, a local typedef hash table used when printing a > > - type. */ > > - typedef_hash_table *local_typedefs; > > - > > - /* If not NULL, a global typedef hash table used when printing a > > - type. */ > > - typedef_hash_table *global_typedefs; > > - > > - /* The list of type printers associated with the global typedef > > - table. This is intentionally opaque. */ > > - struct ext_lang_type_printers *global_printers; > > -}; > > - > > extern const struct type_print_options type_print_raw_options; > > /* A hash table holding typedef_field objects. This is more