public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] sim: common: rename sim_print_config
@ 2021-01-03  7:33 Mike Frysinger
  2021-01-04 11:04 ` Andrew Burgess
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2021-01-03  7:33 UTC (permalink / raw)
  To: gdb-patches

print_sim_config has never been used anywhere, so rename it to follow
the sim_* naming style for all other symbols we export.
---
 sim/common/sim-config.c | 2 +-
 sim/common/sim-config.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

sim/common/:

	* sim-config.c (print_sim_config): Rename to ...
	(sim_config_print): ... this.
	* sim-config.h: Likewise.

diff --git a/sim/common/sim-config.c b/sim/common/sim-config.c
index ba3e372c1592..2acd1e4f77af 100644
--- a/sim/common/sim-config.c
+++ b/sim/common/sim-config.c
@@ -294,7 +294,7 @@ sim_config (SIM_DESC sd)
 
 
 void
-print_sim_config (SIM_DESC sd)
+sim_config_print (SIM_DESC sd)
 {
   sim_io_printf (sd, "WITH_TARGET_BYTE_ORDER = %s\n",
 		 config_byte_order_to_a (WITH_TARGET_BYTE_ORDER));
diff --git a/sim/common/sim-config.h b/sim/common/sim-config.h
index 8e70bc8210b5..6ab8d1a97eca 100644
--- a/sim/common/sim-config.h
+++ b/sim/common/sim-config.h
@@ -313,7 +313,7 @@ extern SIM_RC sim_config (SIM_DESC sd);
 
 /* Print the simulator configuration.  */
 
-extern void print_sim_config (SIM_DESC sd);
+extern void sim_config_print (SIM_DESC sd);
 
 
 #endif
-- 
2.28.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sim: common: rename sim_print_config
  2021-01-03  7:33 [PATCH] sim: common: rename sim_print_config Mike Frysinger
@ 2021-01-04 11:04 ` Andrew Burgess
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Burgess @ 2021-01-04 11:04 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: gdb-patches

* Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-03 02:33:49 -0500]:

> print_sim_config has never been used anywhere, so rename it to follow
> the sim_* naming style for all other symbols we export.
> ---
>  sim/common/sim-config.c | 2 +-
>  sim/common/sim-config.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> sim/common/:
> 
> 	* sim-config.c (print_sim_config): Rename to ...
> 	(sim_config_print): ... this.
> 	* sim-config.h: Likewise.

LGTM.

Thanks,
Andrew


> 
> diff --git a/sim/common/sim-config.c b/sim/common/sim-config.c
> index ba3e372c1592..2acd1e4f77af 100644
> --- a/sim/common/sim-config.c
> +++ b/sim/common/sim-config.c
> @@ -294,7 +294,7 @@ sim_config (SIM_DESC sd)
>  
>  
>  void
> -print_sim_config (SIM_DESC sd)
> +sim_config_print (SIM_DESC sd)
>  {
>    sim_io_printf (sd, "WITH_TARGET_BYTE_ORDER = %s\n",
>  		 config_byte_order_to_a (WITH_TARGET_BYTE_ORDER));
> diff --git a/sim/common/sim-config.h b/sim/common/sim-config.h
> index 8e70bc8210b5..6ab8d1a97eca 100644
> --- a/sim/common/sim-config.h
> +++ b/sim/common/sim-config.h
> @@ -313,7 +313,7 @@ extern SIM_RC sim_config (SIM_DESC sd);
>  
>  /* Print the simulator configuration.  */
>  
> -extern void print_sim_config (SIM_DESC sd);
> +extern void sim_config_print (SIM_DESC sd);
>  
>  
>  #endif
> -- 
> 2.28.0
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-04 11:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-03  7:33 [PATCH] sim: common: rename sim_print_config Mike Frysinger
2021-01-04 11:04 ` Andrew Burgess

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).