From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 545C7385702C for ; Wed, 6 Jan 2021 09:50:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 545C7385702C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x32e.google.com with SMTP id r4so2056315wmh.5 for ; Wed, 06 Jan 2021 01:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rAG3RIkeAVlokQLb7J2hHNO+nUyX6fgmvWz2r4tReJI=; b=H27RomVZasqV+ftYORA4ljvFdtVhC/LHEb+4ZDfHKkEWFseUQtv5/0kzL/aQiktLXn 59GAVODiJB5c+U9IcZ/HB+i7jpMe82n8a+43E6vj8M060QNMw4uxq7RBJH1DeEdJ6HYM aZVrcNZV5FJU7YI7TKTe+r6tZ3zN7mAOP1DqOjhxwH0iN7BzTrbq5/WK1jlt8q4m+GDQ m8UtSUTtbwop7KIoPG3yjyyEIVD3uoFASsATlrH292JhTYWdTceyVO6tWG4u5Le5XJKB LvD46Vm70GMVzUhUv8kNewKOXa+1dktszy7S7f8T4tZXy+uExTBfZn+3XoLf9IiIgdHs IkIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rAG3RIkeAVlokQLb7J2hHNO+nUyX6fgmvWz2r4tReJI=; b=W4MmltYeFjQNSsq5pTwXkAqi2Q1NtsOQXwUnz/y8/lrJNGIu0HEd52/At4HxRjKgxN Nfm06fw7Hwkrboihh/NqVcmSjBUy5jDxfC6SaiLtBi7fOspoxW3a/n07omaJt0PqSk3o qW+tml9OEBaPTb9flGxQS9VqQcLW5THCYHhKfuR804UEdFEIfGVCmxRAG7m+gizBjFtu 3oFyo74CnSIo+JZbwEn2ft97LKuF32KrhzGAh8b7NcLKAe6AZl0IQYrmdiMeHRLzN1Op T0ofs2EuOEW+bPbLk4mrMWq69/nVO/e2orKf4oAPtpSdh+G9jJIKhqUiQq3ZUkE1l+BQ mU7w== X-Gm-Message-State: AOAM532L2y+/kRVoGSK7xYxjKvjOw+wdo1QkkPmJEKuKNK7KpQD01Vv7 ctBWpUNE4U1tnKqeRUDYc/VkRM/r8r/tLw== X-Google-Smtp-Source: ABdhPJwcyaSNn0TZGwBJXsUhc/uI+ERdUCsXxIvGoHpgu3qiKhoLumaxQaycsHXJOThOKcJp0Qm6jg== X-Received: by 2002:a7b:cbda:: with SMTP id n26mr2954196wmi.144.1609926648201; Wed, 06 Jan 2021 01:50:48 -0800 (PST) Received: from localhost (host86-166-129-230.range86-166.btcentralplus.com. [86.166.129.230]) by smtp.gmail.com with ESMTPSA id r7sm2337032wmh.2.2021.01.06.01.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jan 2021 01:50:47 -0800 (PST) Date: Wed, 6 Jan 2021 09:50:46 +0000 From: Andrew Burgess To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] gdb: make record-btrace target clear its async event handler in wait Message-ID: <20210106095046.GG2945@embecosm.com> References: <20201130165251.830482-1-simon.marchi@efficios.com> <20201130165251.830482-4-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130165251.830482-4-simon.marchi@efficios.com> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 09:50:38 up 28 days, 14:35, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2021 09:50:50 -0000 * Simon Marchi via Gdb-patches [2020-11-30 11:52:50 -0500]: > For the same reason explained in the previous patch (which was for the > remote target), move clearing of the async event handler of the > record-btrace target to the wait method. > > The record-btrace target already re-sets its async event handler if > needed in its wait method, so that part doesn't need to be changed: > > /* In async mode, we need to announce further events. */ > if (target_is_async_p ()) > record_btrace_maybe_mark_async_event (moving, no_history); > > gdb/ChangeLog: > > * record-btrace.c (record_btrace_handle_async_inferior_event): > Don't clear async event handler. > (record_btrace_target::wait): Clear async event handler at > beginning. LGTM. > > Change-Id: Ib32087a81bf94f1b884a938c8167ac8bbe09e362 > --- > gdb/record-btrace.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c > index d5338c74aed..aca76dae0dd 100644 > --- a/gdb/record-btrace.c > +++ b/gdb/record-btrace.c > @@ -326,7 +326,6 @@ record_btrace_auto_disable (void) > static void > record_btrace_handle_async_inferior_event (gdb_client_data data) > { > - clear_async_event_handler (record_btrace_async_inferior_event_handler); > inferior_event_handler (INF_REG_EVENT); > } > > @@ -2543,6 +2542,9 @@ record_btrace_target::wait (ptid_t ptid, struct target_waitstatus *status, > std::vector moving; > std::vector no_history; > > + /* Clear this, if needed we'll re-mark it below. */ > + clear_async_event_handler (record_btrace_async_inferior_event_handler); > + > DEBUG ("wait %s (0x%x)", target_pid_to_str (ptid).c_str (), > (unsigned) options); > > -- > 2.29.2 >