[PATCH] sim: always call SIM_AC_OPTION_WARNINGS

[PATCH] sim: always call SIM_AC_OPTION_WARNINGS

[Mike Frysinger]

Now that all ports have opted in to this, we can require it in the
core.  It guarantees that new ports have them turned on, and defaults
to -Werror in the hopes that new ports keep their code clean from the
start.  We do this as a sep commit to make it clear that there are no
changes to existing ports as they've all explicitly called it already.
---
 sim/common/ChangeLog    | 4 ++++
 sim/common/acinclude.m4 | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog
index 4e81a14802a6..d97907a56f20 100644
--- a/sim/common/ChangeLog
+++ b/sim/common/ChangeLog
@@ -1,3 +1,7 @@
+2021-01-09  Mike Frysinger  <vapier@gentoo.org>
+
+	* acinclude.m4 (SIM_AC_OUTPUT): Require SIM_AC_OPTION_WARNINGS.
+
 2021-01-09  Mike Frysinger  <vapier@gentoo.org>
 
 	* acinclude.m4 (SIM_AC_COMMON): Delete checks for stdlib.h, string.h,
diff --git a/sim/common/acinclude.m4 b/sim/common/acinclude.m4
index 45ec134d6d76..149ddc79faa9 100644
--- a/sim/common/acinclude.m4
+++ b/sim/common/acinclude.m4
@@ -821,7 +821,9 @@ dnl one afterwards.  The two pieces of the common fragment are inserted into
 dnl the target's fragment at the appropriate points.
 
 AC_DEFUN([SIM_AC_OUTPUT],
-[
+[dnl
+AC_REQUIRE([SIM_AC_OPTION_WARNINGS])dnl
+
 dnl Make @cgen_breaks@ non-null only if the sim uses CGEN.
 cgen_breaks=""
 if grep CGEN_MAINT $srcdir/Makefile.in >/dev/null; then
-- 
2.28.0

Re: [PATCH] sim: always call SIM_AC_OPTION_WARNINGS

[Andrew Burgess]

* Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-09 14:47:22 -0500]:

> Now that all ports have opted in to this, we can require it in the
> core.  It guarantees that new ports have them turned on, and defaults
> to -Werror in the hopes that new ports keep their code clean from the
> start.  We do this as a sep commit to make it clear that there are no
> changes to existing ports as they've all explicitly called it already.

LGTM.

Thanks,
Andrew

> ---
>  sim/common/ChangeLog    | 4 ++++
>  sim/common/acinclude.m4 | 4 +++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog
> index 4e81a14802a6..d97907a56f20 100644
> --- a/sim/common/ChangeLog
> +++ b/sim/common/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-01-09  Mike Frysinger  <vapier@gentoo.org>
> +
> +	* acinclude.m4 (SIM_AC_OUTPUT): Require SIM_AC_OPTION_WARNINGS.
> +
>  2021-01-09  Mike Frysinger  <vapier@gentoo.org>
>  
>  	* acinclude.m4 (SIM_AC_COMMON): Delete checks for stdlib.h, string.h,
> diff --git a/sim/common/acinclude.m4 b/sim/common/acinclude.m4
> index 45ec134d6d76..149ddc79faa9 100644
> --- a/sim/common/acinclude.m4
> +++ b/sim/common/acinclude.m4
> @@ -821,7 +821,9 @@ dnl one afterwards.  The two pieces of the common fragment are inserted into
>  dnl the target's fragment at the appropriate points.
>  
>  AC_DEFUN([SIM_AC_OUTPUT],
> -[
> +[dnl
> +AC_REQUIRE([SIM_AC_OPTION_WARNINGS])dnl
> +
>  dnl Make @cgen_breaks@ non-null only if the sim uses CGEN.
>  cgen_breaks=""
>  if grep CGEN_MAINT $srcdir/Makefile.in >/dev/null; then
> -- 
> 2.28.0
>