* [PATCH] gdb: remove unused f77_array_offset_tbl from f-valprint.c
@ 2021-01-21 1:56 Simon Marchi
2021-01-21 18:50 ` Tom Tromey
0 siblings, 1 reply; 6+ messages in thread
From: Simon Marchi @ 2021-01-21 1:56 UTC (permalink / raw)
To: gdb-patches
This variable appears to be unused. Its uses were removed in commit
3e2e34f8623d ("fort_dyn_array: Use value constructor instead of
raw-buffer manipulation.") back in 2016.
gdb/ChangeLog:
* f-valprint.c (f77_array_offset_tbl): Remove.
Change-Id: I39ff8d1b402e54ca2ade936f65e540f500cce86e
---
gdb/f-valprint.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/gdb/f-valprint.c b/gdb/f-valprint.c
index 613da3e46969..066827f21f2b 100644
--- a/gdb/f-valprint.c
+++ b/gdb/f-valprint.c
@@ -39,11 +39,6 @@
static void f77_get_dynamic_length_of_aggregate (struct type *);
-int f77_array_offset_tbl[MAX_FORTRAN_DIMS + 1][2];
-
-/* Array which holds offsets to be applied to get a row's elements
- for a given array. Array also holds the size of each subarray. */
-
LONGEST
f77_get_lowerbound (struct type *type)
{
--
2.30.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gdb: remove unused f77_array_offset_tbl from f-valprint.c
2021-01-21 1:56 [PATCH] gdb: remove unused f77_array_offset_tbl from f-valprint.c Simon Marchi
@ 2021-01-21 18:50 ` Tom Tromey
2021-01-21 19:08 ` Simon Marchi
0 siblings, 1 reply; 6+ messages in thread
From: Tom Tromey @ 2021-01-21 18:50 UTC (permalink / raw)
To: Simon Marchi via Gdb-patches
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> This variable appears to be unused. Its uses were removed in commit
Simon> 3e2e34f8623d ("fort_dyn_array: Use value constructor instead of
Simon> raw-buffer manipulation.") back in 2016.
Simon> gdb/ChangeLog:
Simon> * f-valprint.c (f77_array_offset_tbl): Remove.
Seems reasonable to me.
Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gdb: remove unused f77_array_offset_tbl from f-valprint.c
2021-01-21 18:50 ` Tom Tromey
@ 2021-01-21 19:08 ` Simon Marchi
0 siblings, 0 replies; 6+ messages in thread
From: Simon Marchi @ 2021-01-21 19:08 UTC (permalink / raw)
To: Tom Tromey, Simon Marchi via Gdb-patches
On 2021-01-21 1:50 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> This variable appears to be unused. Its uses were removed in commit
> Simon> 3e2e34f8623d ("fort_dyn_array: Use value constructor instead of
> Simon> raw-buffer manipulation.") back in 2016.
>
> Simon> gdb/ChangeLog:
>
> Simon> * f-valprint.c (f77_array_offset_tbl): Remove.
>
> Seems reasonable to me.
>
> Tom
>
Thanks, pushed.
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gdb: remove unused f77_array_offset_tbl from f-valprint.c
2021-01-12 7:01 ` Metzger, Markus T
@ 2021-01-12 15:28 ` Simon Marchi
0 siblings, 0 replies; 6+ messages in thread
From: Simon Marchi @ 2021-01-12 15:28 UTC (permalink / raw)
To: Metzger, Markus T; +Cc: gdb-patches
On 2021-01-12 2:01 a.m., Metzger, Markus T wrote:
> That comment probably belongs to the array.
Oh, it was attached to the macros that were removed, that were using
the f77_array_offset_tbl. I'll update my patch to remove it as well,
thanks for the tip.
Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] gdb: remove unused f77_array_offset_tbl from f-valprint.c
2021-01-12 5:50 Simon Marchi
@ 2021-01-12 7:01 ` Metzger, Markus T
2021-01-12 15:28 ` Simon Marchi
0 siblings, 1 reply; 6+ messages in thread
From: Metzger, Markus T @ 2021-01-12 7:01 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
Hello Simon,
> -int f77_array_offset_tbl[MAX_FORTRAN_DIMS + 1][2];
> -
> /* Array which holds offsets to be applied to get a row's elements
> for a given array. Array also holds the size of each subarray. */
That comment probably belongs to the array.
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] gdb: remove unused f77_array_offset_tbl from f-valprint.c
@ 2021-01-12 5:50 Simon Marchi
2021-01-12 7:01 ` Metzger, Markus T
0 siblings, 1 reply; 6+ messages in thread
From: Simon Marchi @ 2021-01-12 5:50 UTC (permalink / raw)
To: gdb-patches
This variable appears to be unused. Its uses were removed in commit
3e2e34f8623d ("fort_dyn_array: Use value constructor instead of
raw-buffer manipulation.") back in 2016.
gdb/ChangeLog:
* f-valprint.c (f77_array_offset_tbl): Remove.
Change-Id: I39ff8d1b402e54ca2ade936f65e540f500cce86e
---
gdb/f-valprint.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/gdb/f-valprint.c b/gdb/f-valprint.c
index 613da3e46969..befa4c72174e 100644
--- a/gdb/f-valprint.c
+++ b/gdb/f-valprint.c
@@ -39,8 +39,6 @@
static void f77_get_dynamic_length_of_aggregate (struct type *);
-int f77_array_offset_tbl[MAX_FORTRAN_DIMS + 1][2];
-
/* Array which holds offsets to be applied to get a row's elements
for a given array. Array also holds the size of each subarray. */
--
2.29.2
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-21 19:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 1:56 [PATCH] gdb: remove unused f77_array_offset_tbl from f-valprint.c Simon Marchi
2021-01-21 18:50 ` Tom Tromey
2021-01-21 19:08 ` Simon Marchi
-- strict thread matches above, loose matches on Subject: below --
2021-01-12 5:50 Simon Marchi
2021-01-12 7:01 ` Metzger, Markus T
2021-01-12 15:28 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).