From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Add test case for symbol menu for local enumerators
Date: Mon, 25 Jan 2021 11:55:38 +0400 [thread overview]
Message-ID: <20210125075538.GB1762869@adacore.com> (raw)
In-Reply-To: <20210122211023.997478-2-tromey@adacore.com>
Hi Tom,
> Ada will normally present a menu to the user to allow manual
> disambiguation of symbols. The AdaCore internal GDB had a bug that
> prevented this from happening. Although this bug is not in the FSF
> GDB, it seemed worthwhile to write a test case to ensure this.
>
> gdb/testsuite/ChangeLog
> 2021-01-22 Tom Tromey <tromey@adacore.com>
>
> * gdb.ada/local-enum.exp: New file.
> * gdb.ada/local-enum/local.adb: New file.
This patch looks good to me.
Thank you for submitting it :).
--
Joel
next prev parent reply other threads:[~2021-01-25 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 21:10 [PATCH 0/2] Add another case to Ada expression resolution Tom Tromey
2021-01-22 21:10 ` [PATCH 1/2] Add test case for symbol menu for local enumerators Tom Tromey
2021-01-25 7:55 ` Joel Brobecker [this message]
2021-01-22 21:10 ` [PATCH 2/2] Specially handle array contexts in Ada expression resolution Tom Tromey
2021-01-25 7:57 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125075538.GB1762869@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).