public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Markus Metzger <markus.t.metzger@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 7/8] testsuite, gdb.btrace: adjust expected source line in non-stop.exp
Date: Thu,  4 Feb 2021 09:10:36 +0100	[thread overview]
Message-ID: <20210204081037.3712162-11-markus.t.metzger@intel.com> (raw)
In-Reply-To: <20210204081037.3712162-1-markus.t.metzger@intel.com>

In gdb.btrace/non-stop.exp, we hard-code expected source lines assuming we
know how they would match to the recorded trace.  Despite the fact that we
should really have been using an assembly source, the assumptions work
pretty well.

With clang-6 -m32, we found a case where the assumptions do not hold.
Adjust the expected source lines a little bit to cover that case, as well.

Should we run into more cases like this, we will have to switch to an
assembly source file.

gdb/testsuite/ChangeLog:
2020-12-17  Markus Metzger  <markus.t.metzger@intel.com>

	* gdb.btrace/non-stop.exp: Adjust expected source lines.
---
 gdb/testsuite/gdb.btrace/non-stop.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.btrace/non-stop.exp b/gdb/testsuite/gdb.btrace/non-stop.exp
index 40cced7a8bb..e509d65d660 100644
--- a/gdb/testsuite/gdb.btrace/non-stop.exp
+++ b/gdb/testsuite/gdb.btrace/non-stop.exp
@@ -111,10 +111,10 @@ gdb_test "thread apply all info rec" ".*"
 gdb_test "info threads" ".*"
 
 with_test_prefix "navigate" {
-    gdb_test "thread apply 1 record goto 2" "$loop_line"
+    gdb_test "thread apply 1 record goto 3" "$loop_line"
     gdb_test "thread apply 2 record goto 4" "$loop_line"
     gdb_test "thread apply 1 info record" \
-        ".*Replay in progress\.  At instruction 2\." "thread 1 at insn 2"
+        ".*Replay in progress\.  At instruction 3\." "thread 1 at insn 3"
     gdb_test "thread apply 2 info record" \
         ".*Replay in progress\.  At instruction 4\." "thread 2 at insn 4"
 
-- 
2.26.2

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  parent reply	other threads:[~2021-02-04  8:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  8:10 [PATCH 0/8] pass gdb.btrace with clang Markus Metzger
2021-02-04  8:10 ` [PATCH 1/2] gdb, btrace: fix hang when stepping over a breakpoint at the end of the trace Markus Metzger
2021-02-04  8:10 ` [PATCH 1/8] testsuite: extend nopie handling to add -fno-pie to compiler flags Markus Metzger
2021-03-02 16:00   ` Simon Marchi
2021-03-03  7:57     ` Metzger, Markus T
2021-02-04  8:10 ` [PATCH] testsuite: note on use_gdb_stub usage Markus Metzger
2021-02-26  7:48   ` Metzger, Markus T
2021-02-04  8:10 ` [PATCH 2/2] gdb, record: move no-history notification into normal_stop Markus Metzger
2021-02-04  8:10 ` [PATCH 2/8] testsuite, gdb.btrace: remove assembly-check in delta.exp Markus Metzger
2021-02-04  8:10 ` [PATCH 3/8] testsuite, gdb.btrace: pass rn-dl-bind.exp with clang Markus Metzger
2021-02-04  8:10 ` [PATCH 4/8] testsuite, gdb.btrace: move -Wl,-x to ldflags Markus Metzger
2021-02-04  8:10 ` [PATCH 5/8] testsuite, gdb.btrace: adjust expected output to pass with clang Markus Metzger
2021-02-04  8:10 ` [PATCH 6/8] testsuite, gdb.btrace: remove implicit debug option in stepi.exp Markus Metzger
2021-02-04  8:10 ` Markus Metzger [this message]
2021-02-04  8:10 ` [PATCH 8/8] gdb, testsuite: enforce lazy binding for gdb.btrace/rn-dl-bind.exp Markus Metzger
2021-02-26  7:50 ` [PATCH 0/8] pass gdb.btrace with clang Metzger, Markus T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204081037.3712162-11-markus.t.metzger@intel.com \
    --to=markus.t.metzger@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).