public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Markus Metzger <markus.t.metzger@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 8/8] gdb, testsuite: enforce lazy binding for gdb.btrace/rn-dl-bind.exp
Date: Thu,  4 Feb 2021 09:10:37 +0100	[thread overview]
Message-ID: <20210204081037.3712162-12-markus.t.metzger@intel.com> (raw)
In-Reply-To: <20210204081037.3712162-1-markus.t.metzger@intel.com>

In gdb.btrace/rn-dl-bind.exp we test that we can reverse-step over
recorded dynamic linking.  The test covers specific behaviour to support
_dl_runtime_resolve calling the resolved function by returning to it.
This would normally mess up stepping as we'd end up with backtraces that
contain the same functions but different frame ids.

Since GDB needs to recognize a return from _dl_runtime_resolve, the test
only passes when debug information for _dl_runtime_resolve is available.

The test requires that symbols are bound lazily.  Otherwise, we won't
record dynamic linking and the test will be fairly pointless.

Recent GCC pass -z now by default to bind symbols eagerly.  Add -z lazy to
the test's ldflags to enforce lazy binding.

gdb/testsuite/ChangeLog:
2021-01-13  Markus Metzger  <markus.t.metzger@intel.com>

	* gdb.btrace/rn-dl-bind.exp: Add ldflags=-Wl,-z,lazy.
---
 gdb/testsuite/gdb.btrace/rn-dl-bind.exp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.btrace/rn-dl-bind.exp b/gdb/testsuite/gdb.btrace/rn-dl-bind.exp
index 65e445334af..204e88093a4 100644
--- a/gdb/testsuite/gdb.btrace/rn-dl-bind.exp
+++ b/gdb/testsuite/gdb.btrace/rn-dl-bind.exp
@@ -27,7 +27,8 @@ if { [skip_btrace_tests] } {
 }
 
 standard_testfile
-if [prepare_for_testing "failed to prepare" $testfile $srcfile {c++ debug}] {
+if [prepare_for_testing "failed to prepare" $testfile $srcfile \
+	{c++ debug ldflags=-Wl,-z,lazy}] {
     return -1
 }
 
-- 
2.26.2

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


  parent reply	other threads:[~2021-02-04  8:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  8:10 [PATCH 0/8] pass gdb.btrace with clang Markus Metzger
2021-02-04  8:10 ` [PATCH 1/2] gdb, btrace: fix hang when stepping over a breakpoint at the end of the trace Markus Metzger
2021-02-04  8:10 ` [PATCH 1/8] testsuite: extend nopie handling to add -fno-pie to compiler flags Markus Metzger
2021-03-02 16:00   ` Simon Marchi
2021-03-03  7:57     ` Metzger, Markus T
2021-02-04  8:10 ` [PATCH] testsuite: note on use_gdb_stub usage Markus Metzger
2021-02-26  7:48   ` Metzger, Markus T
2021-02-04  8:10 ` [PATCH 2/2] gdb, record: move no-history notification into normal_stop Markus Metzger
2021-02-04  8:10 ` [PATCH 2/8] testsuite, gdb.btrace: remove assembly-check in delta.exp Markus Metzger
2021-02-04  8:10 ` [PATCH 3/8] testsuite, gdb.btrace: pass rn-dl-bind.exp with clang Markus Metzger
2021-02-04  8:10 ` [PATCH 4/8] testsuite, gdb.btrace: move -Wl,-x to ldflags Markus Metzger
2021-02-04  8:10 ` [PATCH 5/8] testsuite, gdb.btrace: adjust expected output to pass with clang Markus Metzger
2021-02-04  8:10 ` [PATCH 6/8] testsuite, gdb.btrace: remove implicit debug option in stepi.exp Markus Metzger
2021-02-04  8:10 ` [PATCH 7/8] testsuite, gdb.btrace: adjust expected source line in non-stop.exp Markus Metzger
2021-02-04  8:10 ` Markus Metzger [this message]
2021-02-26  7:50 ` [PATCH 0/8] pass gdb.btrace with clang Metzger, Markus T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204081037.3712162-12-markus.t.metzger@intel.com \
    --to=markus.t.metzger@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).