From: Markus Metzger <markus.t.metzger@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/2] gdb, record: move no-history notification into normal_stop
Date: Thu, 4 Feb 2021 09:10:30 +0100 [thread overview]
Message-ID: <20210204081037.3712162-5-markus.t.metzger@intel.com> (raw)
In-Reply-To: <20210204081037.3712162-1-markus.t.metzger@intel.com>
Leave calling gdb::observers::no_history.notify to normal_stop based on
the last waitstatus.
gdb/ChangeLog:
2021-01-15 Markus Metzger <markus.t.metzger@intel.com>
* infrun.c (handle_inferior_event): Remove no-history notification.
(keep_going_pass_signal): Likewise. Set last waitstatus.
(normal_stop): Notify no-history observers.
---
gdb/infrun.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 21513344be1..2de86f80274 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -5542,7 +5542,6 @@ handle_inferior_event (struct execution_control_state *ecs)
if (handle_stop_requested (ecs))
return;
- gdb::observers::no_history.notify ();
stop_waiting (ecs);
return;
}
@@ -7829,7 +7828,8 @@ keep_going_pass_signal (struct execution_control_state *ecs)
if (ecs->event_thread->control.is_replaying
&& !target_record_is_replaying (ecs->event_thread->ptid))
{
- gdb::observers::no_history.notify ();
+ ecs->ws.kind = TARGET_WAITKIND_NO_HISTORY;
+ target_last_waitstatus = ecs->ws;
stop_waiting (ecs);
normal_stop ();
return;
@@ -8457,6 +8457,9 @@ normal_stop (void)
return 1;
}
+ if (last.kind == TARGET_WAITKIND_NO_HISTORY)
+ gdb::observers::no_history.notify ();
+
/* Notify observers about the stop. This is where the interpreters
print the stop event. */
if (inferior_ptid != null_ptid)
--
2.26.2
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2021-02-04 8:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:10 [PATCH 0/8] pass gdb.btrace with clang Markus Metzger
2021-02-04 8:10 ` [PATCH 1/2] gdb, btrace: fix hang when stepping over a breakpoint at the end of the trace Markus Metzger
2021-02-04 8:10 ` [PATCH 1/8] testsuite: extend nopie handling to add -fno-pie to compiler flags Markus Metzger
2021-03-02 16:00 ` Simon Marchi
2021-03-03 7:57 ` Metzger, Markus T
2021-02-04 8:10 ` [PATCH] testsuite: note on use_gdb_stub usage Markus Metzger
2021-02-26 7:48 ` Metzger, Markus T
2021-02-04 8:10 ` Markus Metzger [this message]
2021-02-04 8:10 ` [PATCH 2/8] testsuite, gdb.btrace: remove assembly-check in delta.exp Markus Metzger
2021-02-04 8:10 ` [PATCH 3/8] testsuite, gdb.btrace: pass rn-dl-bind.exp with clang Markus Metzger
2021-02-04 8:10 ` [PATCH 4/8] testsuite, gdb.btrace: move -Wl,-x to ldflags Markus Metzger
2021-02-04 8:10 ` [PATCH 5/8] testsuite, gdb.btrace: adjust expected output to pass with clang Markus Metzger
2021-02-04 8:10 ` [PATCH 6/8] testsuite, gdb.btrace: remove implicit debug option in stepi.exp Markus Metzger
2021-02-04 8:10 ` [PATCH 7/8] testsuite, gdb.btrace: adjust expected source line in non-stop.exp Markus Metzger
2021-02-04 8:10 ` [PATCH 8/8] gdb, testsuite: enforce lazy binding for gdb.btrace/rn-dl-bind.exp Markus Metzger
2021-02-26 7:50 ` [PATCH 0/8] pass gdb.btrace with clang Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204081037.3712162-5-markus.t.metzger@intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).