From: Shahab Vahedi <shahab.vahedi@gmail.com>
To: gdb-patches@sourceware.org
Cc: Shahab Vahedi <shahab.vahedi@gmail.com>,
Shahab Vahedi <shahab@synopsys.com>,
Andrew Burgess <andrew.burgess@embecosm.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: [PUSHED] gdb: Use correct feature in tdesc-regs for ARC
Date: Thu, 4 Feb 2021 20:35:00 +0100 [thread overview]
Message-ID: <20210204193500.963-1-shahab.vahedi@gmail.com> (raw)
In-Reply-To: <20210125230244.12445-1-shahab.vahedi@gmail.com>
From: Shahab Vahedi <shahab@synopsys.com>
tdesc-regs.exp test fails for ARC because the test is not
using the correct XML files as target description. With
this change, the correct directory and files are used.
v2 (after Andrew's remark [1]):
- Update the feature file names again. Test results now:
Test run by shahab on Tue Jan 26 11:31:16 2021
Target is arc-default-elf32
Host is x86_64-unknown-linux-gnu
=== gdb tests ===
Schedule of variations:
arc-nsim
Running target arc-nsim
Running /src/gdb/testsuite/gdb.xml/tdesc-regs.exp ...
PASS: gdb.xml/tdesc-regs.exp: set tdesc file single-reg.xml
PASS: gdb.xml/tdesc-regs.exp: cd to directory holding xml
PASS: gdb.xml/tdesc-regs.exp: set tdesc filename test-extra-regs.xml...
PASS: gdb.xml/tdesc-regs.exp: ptype $extrareg
PASS: gdb.xml/tdesc-regs.exp: ptype $uintreg
PASS: gdb.xml/tdesc-regs.exp: ptype $vecreg
PASS: gdb.xml/tdesc-regs.exp: ptype $unionreg
PASS: gdb.xml/tdesc-regs.exp: ptype $unionreg.v4
PASS: gdb.xml/tdesc-regs.exp: ptype $structreg
PASS: gdb.xml/tdesc-regs.exp: ptype $structreg.v4
PASS: gdb.xml/tdesc-regs.exp: ptype $bitfields
PASS: gdb.xml/tdesc-regs.exp: ptype $flags
PASS: gdb.xml/tdesc-regs.exp: ptype $mixed_flags
PASS: gdb.xml/tdesc-regs.exp: maintenance print reggroups
PASS: gdb.xml/tdesc-regs.exp: core-only.xml: set tdesc filename...
PASS: gdb.xml/tdesc-regs.exp: core-only.xml: ptype $extrareg
=== gdb Summary ===
# of expected passes 16
[1]
https://sourceware.org/pipermail/gdb-patches/2021-January/175465.html
gdb/testsuite/ChangeLog:
* gdb.xml/tdesc-regs.exp: Use correct core-regs for ARC.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.xml/tdesc-regs.exp | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 62c06d0f52c..a449de04587 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2021-02-04 Shahab Vahedi <shahab@synopsys.com>
+
+ * gdb.xml/tdesc-regs.exp: Use correct core-regs for ARC.
+
2021-02-03 Pedro Alves <pedro@palves.net>
* gdb.threads/detach-step-over.c: New file.
diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp b/gdb/testsuite/gdb.xml/tdesc-regs.exp
index 1ee6ae1bff3..7402ba8d952 100644
--- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
+++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
@@ -32,7 +32,8 @@ switch -glob -- [istarget] {
}
"arc*-*-*" {
set architecture "arc:ARCv2"
- set core-regs {arc-v2.xml}
+ set regdir "arc/"
+ set core-regs {v2-core.xml v2-aux.xml}
}
"arm*-*-*" {
set regdir "arm/"
--
2.30.0
prev parent reply other threads:[~2021-02-04 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 23:02 [PATCH] " Shahab Vahedi
2021-01-26 9:17 ` Andrew Burgess
2021-01-26 11:02 ` Shahab Vahedi
2021-01-26 10:47 ` [PATCH v2] " Shahab Vahedi
2021-02-04 19:35 ` Shahab Vahedi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204193500.963-1-shahab.vahedi@gmail.com \
--to=shahab.vahedi@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).