* [PATCH] gdb: Use correct feature in tdesc-regs for ARC
@ 2021-01-25 23:02 Shahab Vahedi
2021-01-26 9:17 ` Andrew Burgess
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Shahab Vahedi @ 2021-01-25 23:02 UTC (permalink / raw)
To: gdb-patches; +Cc: Shahab Vahedi, Shahab Vahedi, Francois Bedard
From: Shahab Vahedi <shahab@synopsys.com>
tdesc-regs.exp test fails for ARC because the test is not
using the correct XML files as target description. With
this change, the correct directory and files are used.
gdb/testsuite/ChangeLog:
* gdb.xml/tdesc-regs.exp: Use correct core-regs for ARC.
---
gdb/testsuite/gdb.xml/tdesc-regs.exp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp b/gdb/testsuite/gdb.xml/tdesc-regs.exp
index 1ee6ae1bff3..8ab39649c94 100644
--- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
+++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
@@ -32,7 +32,8 @@ switch -glob -- [istarget] {
}
"arc*-*-*" {
set architecture "arc:ARCv2"
- set core-regs {arc-v2.xml}
+ set regdir "arc/"
+ set core-regs {core-v2.xml aux-v2.xml}
}
"arm*-*-*" {
set regdir "arm/"
--
2.30.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gdb: Use correct feature in tdesc-regs for ARC
2021-01-25 23:02 [PATCH] gdb: Use correct feature in tdesc-regs for ARC Shahab Vahedi
@ 2021-01-26 9:17 ` Andrew Burgess
2021-01-26 11:02 ` Shahab Vahedi
2021-01-26 10:47 ` [PATCH v2] " Shahab Vahedi
2021-02-04 19:35 ` [PUSHED] " Shahab Vahedi
2 siblings, 1 reply; 5+ messages in thread
From: Andrew Burgess @ 2021-01-26 9:17 UTC (permalink / raw)
To: Shahab Vahedi; +Cc: gdb-patches, Shahab Vahedi, Francois Bedard
* Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org> [2021-01-26 00:02:44 +0100]:
> From: Shahab Vahedi <shahab@synopsys.com>
>
> tdesc-regs.exp test fails for ARC because the test is not
> using the correct XML files as target description. With
> this change, the correct directory and files are used.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.xml/tdesc-regs.exp: Use correct core-regs for ARC.
> ---
> gdb/testsuite/gdb.xml/tdesc-regs.exp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp b/gdb/testsuite/gdb.xml/tdesc-regs.exp
> index 1ee6ae1bff3..8ab39649c94 100644
> --- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
> +++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
> @@ -32,7 +32,8 @@ switch -glob -- [istarget] {
> }
> "arc*-*-*" {
> set architecture "arc:ARCv2"
> - set core-regs {arc-v2.xml}
> + set regdir "arc/"
> + set core-regs {core-v2.xml aux-v2.xml}
Maybe I'm either going crazy, or really don't understand this test (do
please correct me), but the contents of gdb/features/arc/ on current
master are:
$ ls gdb/features/arc/
v1-aux.c v1-aux.xml v1-core.c v1-core.xml v2-aux.c v2-aux.xml v2-core.c v2-core.xml
So shouldn't this be:
set core-regs {v2-core.xml v2-aux.xml}
But for a change to only one test file, surely this was tested, right?
So how was it passing for you?
Thanks,
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] gdb: Use correct feature in tdesc-regs for ARC
2021-01-25 23:02 [PATCH] gdb: Use correct feature in tdesc-regs for ARC Shahab Vahedi
2021-01-26 9:17 ` Andrew Burgess
@ 2021-01-26 10:47 ` Shahab Vahedi
2021-02-04 19:35 ` [PUSHED] " Shahab Vahedi
2 siblings, 0 replies; 5+ messages in thread
From: Shahab Vahedi @ 2021-01-26 10:47 UTC (permalink / raw)
To: gdb-patches; +Cc: Shahab Vahedi, Shahab Vahedi, Andrew Burgess, Francois Bedard
From: Shahab Vahedi <shahab@synopsys.com>
tdesc-regs.exp test fails for ARC because the test is not
using the correct XML files as target description. With
this change, the correct directory and files are used.
v2 (after Andrew's remark [1]):
- Update the feature file names again. Test results now:
Test run by shahab on Tue Jan 26 11:31:16 2021
Target is arc-default-elf32
Host is x86_64-unknown-linux-gnu
=== gdb tests ===
Schedule of variations:
arc-nsim
Running target arc-nsim
Running /src/gdb/testsuite/gdb.xml/tdesc-regs.exp ...
PASS: gdb.xml/tdesc-regs.exp: set tdesc file single-reg.xml
PASS: gdb.xml/tdesc-regs.exp: cd to directory holding xml
PASS: gdb.xml/tdesc-regs.exp: set tdesc filename test-extra-regs.xml...
PASS: gdb.xml/tdesc-regs.exp: ptype $extrareg
PASS: gdb.xml/tdesc-regs.exp: ptype $uintreg
PASS: gdb.xml/tdesc-regs.exp: ptype $vecreg
PASS: gdb.xml/tdesc-regs.exp: ptype $unionreg
PASS: gdb.xml/tdesc-regs.exp: ptype $unionreg.v4
PASS: gdb.xml/tdesc-regs.exp: ptype $structreg
PASS: gdb.xml/tdesc-regs.exp: ptype $structreg.v4
PASS: gdb.xml/tdesc-regs.exp: ptype $bitfields
PASS: gdb.xml/tdesc-regs.exp: ptype $flags
PASS: gdb.xml/tdesc-regs.exp: ptype $mixed_flags
PASS: gdb.xml/tdesc-regs.exp: maintenance print reggroups
PASS: gdb.xml/tdesc-regs.exp: core-only.xml: set tdesc filename...
PASS: gdb.xml/tdesc-regs.exp: core-only.xml: ptype $extrareg
=== gdb Summary ===
# of expected passes 16
[1]
https://sourceware.org/pipermail/gdb-patches/2021-January/175465.html
gdb/testsuite/ChangeLog:
* gdb.xml/tdesc-regs.exp: Use correct core-regs for ARC.
---
gdb/testsuite/gdb.xml/tdesc-regs.exp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp b/gdb/testsuite/gdb.xml/tdesc-regs.exp
index 1ee6ae1bff3..7402ba8d952 100644
--- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
+++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
@@ -32,7 +32,8 @@ switch -glob -- [istarget] {
}
"arc*-*-*" {
set architecture "arc:ARCv2"
- set core-regs {arc-v2.xml}
+ set regdir "arc/"
+ set core-regs {v2-core.xml v2-aux.xml}
}
"arm*-*-*" {
set regdir "arm/"
--
2.30.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gdb: Use correct feature in tdesc-regs for ARC
2021-01-26 9:17 ` Andrew Burgess
@ 2021-01-26 11:02 ` Shahab Vahedi
0 siblings, 0 replies; 5+ messages in thread
From: Shahab Vahedi @ 2021-01-26 11:02 UTC (permalink / raw)
To: Andrew Burgess; +Cc: gdb-patches, Shahab Vahedi, Francois Bedard
Hi Andrew,
On Tue, Jan 26, 2021 at 09:17:36AM +0000, Andrew Burgess wrote:
> * Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org> [2021-01-26 00:02:44 +0100]:
>
> > "arc*-*-*" {
> > set architecture "arc:ARCv2"
> > - set core-regs {arc-v2.xml}
> > + set regdir "arc/"
> > + set core-regs {core-v2.xml aux-v2.xml}
>
> Maybe I'm either going crazy, or really don't understand this test (do
> please correct me), but the contents of gdb/features/arc/ on current
> master are:
>
> $ ls gdb/features/arc/
> v1-aux.c v1-aux.xml v1-core.c v1-core.xml v2-aux.c v2-aux.xml v2-core.c v2-core.xml
>
> So shouldn't this be:
>
> set core-regs {v2-core.xml v2-aux.xml}
>
> But for a change to only one test file, surely this was tested, right?
> So how was it passing for you?
You're absolutely right! This was a snafu on my side. This fix happened
chronologically before ARC's XML feature patch [1] evolve to its final form.
I've had marked the previously submitted patch [2] as "ready for upstream"
in my backlog commits and did not execute the tests again. I sincerely
apologise for that.
The new patch is submitted again [3] along with the test results in the
commit message.
[1] arc: Add ARCv2 XML target along with refactoring
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=995d3a197d7a
[2] [PATCH] gdb: Use correct feature in tdesc-regs for ARC
https://sourceware.org/pipermail/gdb-patches/2021-January/175458.html
[3] [PATCH v2] gdb: Use correct feature in tdesc-regs for ARC
https://sourceware.org/pipermail/gdb-patches/2021-January/175476.html
Cheers,
Shahab
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PUSHED] gdb: Use correct feature in tdesc-regs for ARC
2021-01-25 23:02 [PATCH] gdb: Use correct feature in tdesc-regs for ARC Shahab Vahedi
2021-01-26 9:17 ` Andrew Burgess
2021-01-26 10:47 ` [PATCH v2] " Shahab Vahedi
@ 2021-02-04 19:35 ` Shahab Vahedi
2 siblings, 0 replies; 5+ messages in thread
From: Shahab Vahedi @ 2021-02-04 19:35 UTC (permalink / raw)
To: gdb-patches; +Cc: Shahab Vahedi, Shahab Vahedi, Andrew Burgess, Francois Bedard
From: Shahab Vahedi <shahab@synopsys.com>
tdesc-regs.exp test fails for ARC because the test is not
using the correct XML files as target description. With
this change, the correct directory and files are used.
v2 (after Andrew's remark [1]):
- Update the feature file names again. Test results now:
Test run by shahab on Tue Jan 26 11:31:16 2021
Target is arc-default-elf32
Host is x86_64-unknown-linux-gnu
=== gdb tests ===
Schedule of variations:
arc-nsim
Running target arc-nsim
Running /src/gdb/testsuite/gdb.xml/tdesc-regs.exp ...
PASS: gdb.xml/tdesc-regs.exp: set tdesc file single-reg.xml
PASS: gdb.xml/tdesc-regs.exp: cd to directory holding xml
PASS: gdb.xml/tdesc-regs.exp: set tdesc filename test-extra-regs.xml...
PASS: gdb.xml/tdesc-regs.exp: ptype $extrareg
PASS: gdb.xml/tdesc-regs.exp: ptype $uintreg
PASS: gdb.xml/tdesc-regs.exp: ptype $vecreg
PASS: gdb.xml/tdesc-regs.exp: ptype $unionreg
PASS: gdb.xml/tdesc-regs.exp: ptype $unionreg.v4
PASS: gdb.xml/tdesc-regs.exp: ptype $structreg
PASS: gdb.xml/tdesc-regs.exp: ptype $structreg.v4
PASS: gdb.xml/tdesc-regs.exp: ptype $bitfields
PASS: gdb.xml/tdesc-regs.exp: ptype $flags
PASS: gdb.xml/tdesc-regs.exp: ptype $mixed_flags
PASS: gdb.xml/tdesc-regs.exp: maintenance print reggroups
PASS: gdb.xml/tdesc-regs.exp: core-only.xml: set tdesc filename...
PASS: gdb.xml/tdesc-regs.exp: core-only.xml: ptype $extrareg
=== gdb Summary ===
# of expected passes 16
[1]
https://sourceware.org/pipermail/gdb-patches/2021-January/175465.html
gdb/testsuite/ChangeLog:
* gdb.xml/tdesc-regs.exp: Use correct core-regs for ARC.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.xml/tdesc-regs.exp | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 62c06d0f52c..a449de04587 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2021-02-04 Shahab Vahedi <shahab@synopsys.com>
+
+ * gdb.xml/tdesc-regs.exp: Use correct core-regs for ARC.
+
2021-02-03 Pedro Alves <pedro@palves.net>
* gdb.threads/detach-step-over.c: New file.
diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp b/gdb/testsuite/gdb.xml/tdesc-regs.exp
index 1ee6ae1bff3..7402ba8d952 100644
--- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
+++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
@@ -32,7 +32,8 @@ switch -glob -- [istarget] {
}
"arc*-*-*" {
set architecture "arc:ARCv2"
- set core-regs {arc-v2.xml}
+ set regdir "arc/"
+ set core-regs {v2-core.xml v2-aux.xml}
}
"arm*-*-*" {
set regdir "arm/"
--
2.30.0
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-04 19:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 23:02 [PATCH] gdb: Use correct feature in tdesc-regs for ARC Shahab Vahedi
2021-01-26 9:17 ` Andrew Burgess
2021-01-26 11:02 ` Shahab Vahedi
2021-01-26 10:47 ` [PATCH v2] " Shahab Vahedi
2021-02-04 19:35 ` [PUSHED] " Shahab Vahedi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).