From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id 420AB3844008 for ; Mon, 8 Feb 2021 10:58:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 420AB3844008 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x32b.google.com with SMTP id i5so4113916wmq.2 for ; Mon, 08 Feb 2021 02:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aDkRBxslT9leIe+kd/o4AxgoFstUB43dU3+Z4eU0UcM=; b=VAC8Fs+Ump37suH7eBmgtdEvCZHQnV0jnlh3b7f/OakyNsJrSKPez5gfQAH5PTuKUD 9Keabd9zZWHs7yvWKAuEZ98owp/jyYTx27uSDxSkQL9im/dCngLRS/rksonBs/sIl7CJ qhwXIpBjdMmf7ReqWoakWAne4ZLcLYzDKnIz9ojcPdRNXlYjy76YPEYtqwfcZbU8p9M5 ugFbVwv/cyUNNCPQCAVAVDcl3Ze73WZzNkmD/mfD8sRuKot54p8EmiWAK2hZobzdReXo MYkhEY6x+vRoyB1+FmZIMMNmd3c9KAawQrEoARqvH2twjrv6XIK/hFk8lOLCRK69ifIG yH0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aDkRBxslT9leIe+kd/o4AxgoFstUB43dU3+Z4eU0UcM=; b=IISZws4J+Vd0hDmbMD+Aa+PAJ7ql+Am+DqnlUIgo7b6oaDBIWcqJ1vj/35po/L6C0R JeRg7sV8aUmdiWqGo5EcfsaMEQTJ9A5mwGHGLRu44Xg/3peR4bbbOZzFoxqchuypZ9Oi 1hxs+F7L6duTTNbhoDkvQICCVVirmLUDZ5Rzc6MW4Ke7Z8SeZwoLek/q/fwXdUf3mcfA Z73gZkP5y0D2qqCZ0mvcnhCZt4c/FR+MdzbssMm3ursMnOogSqkv0kxDMzvAC1Fs7PS2 rjMaZDytwKLHBzNucXT56bPK/sJRjH+k0NidydMCFQRleDjUG3bzEN18jfLE5267JC0U 0Bww== X-Gm-Message-State: AOAM533YLUkaD9FosFfYRAW3R7iv6kXgvz77Y8FrEOKJgVBnX39ACJQs I17vdrMPybqJntlp0xhbEbY8q3fjgl7kSQ== X-Google-Smtp-Source: ABdhPJw+lBb8JQYNAOqlOGm0sGOKYh4jjyj0tKkcBBROmnO1L1uVmKFlzGN1s+tveTrY4mg/tE7PqA== X-Received: by 2002:a1c:b087:: with SMTP id z129mr14228831wme.147.1612781935943; Mon, 08 Feb 2021 02:58:55 -0800 (PST) Received: from localhost (host109-151-46-64.range109-151.btcentralplus.com. [109.151.46.64]) by smtp.gmail.com with ESMTPSA id c3sm24000982wrr.6.2021.02.08.02.58.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 02:58:55 -0800 (PST) Date: Mon, 8 Feb 2021 10:58:54 +0000 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCH 06/11] sim/rx: use puts instead of printf in a few places Message-ID: <20210208105854.GD265215@embecosm.com> References: <594cd64926e070920c8860baa08e9e55f0c7c9c3.1612179773.git.andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 10:57:38 up 61 days, 15:42, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 10:58:58 -0000 * Mike Frysinger [2021-02-01 09:49:00 -0500]: > On 01 Feb 2021 11:44, Andrew Burgess wrote: > > Calling printf with the format being a non constant string results in > > a GCC warning. Use puts instead in a few places. > > puts() outputs the string with a trailing newline. > doesn't seem equiv in this code ? > > i change to printf ("%s", ...) to avoid these warnings. Good point, I think I got confused with fputs :( I made the change back to printf inline with your suggestion. Thanks, Andrew