From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 01/11] sim/rx: define sim_memory_map
Date: Mon, 8 Feb 2021 11:01:00 +0000 [thread overview]
Message-ID: <20210208110100.GE265215@embecosm.com> (raw)
In-Reply-To: <YBgUVK1Ydi09uGIN@vapier>
* Mike Frysinger <vapier@gentoo.org> [2021-02-01 09:46:44 -0500]:
> On 01 Feb 2021 11:44, Andrew Burgess wrote:
> > The rx simulator doesn't build due to sim_memory_map not being
> > defined. Define it now to return NULL, this can be extended later to
> > return an actual memory map if anyone wants this functionality.
>
> i build every sim port, and rx was/is building fine for me. nothing in
> the sim refers to the sim_memory_map, so it failing to build is a bit
> surprising. do you mean gdb is failing to link instead ? i don't always
> try to build those for ports as not all have gdb ports.
You are correct of course.
I updated the wording of the commit message more inline with the patch
you submitted here:
https://sourceware.org/pipermail/gdb-patches/2021-February/175689.html
Thanks,
Andrew
next prev parent reply other threads:[~2021-02-08 11:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 11:44 [PATCH 00/11] fix build warnings for rx simulator Andrew Burgess
2021-02-01 11:44 ` [PATCH 01/11] sim/rx: define sim_memory_map Andrew Burgess
2021-02-01 14:46 ` Mike Frysinger
2021-02-08 11:01 ` Andrew Burgess [this message]
2021-02-01 11:44 ` [PATCH 02/11] sim/rx: fix an issue where we try to modify a const string Andrew Burgess
2021-02-01 11:44 ` [PATCH 03/11] sim/rx: fill in missing 'void' for empty argument lists Andrew Burgess
2021-02-01 11:44 ` [PATCH 04/11] sim/rx: mark some functions as static Andrew Burgess
2021-02-01 11:44 ` [PATCH 05/11] sim/rx: delete an unused function Andrew Burgess
2021-02-01 11:44 ` [PATCH 06/11] sim/rx: use puts instead of printf in a few places Andrew Burgess
2021-02-01 14:49 ` Mike Frysinger
2021-02-08 10:58 ` Andrew Burgess
2021-02-01 11:44 ` [PATCH 07/11] sim/rx: move some variable declarations to the start of the block Andrew Burgess
2021-02-01 11:44 ` [PATCH 08/11] sim/rx: use PRIx64 in printf format string Andrew Burgess
2021-02-01 11:44 ` [PATCH 09/11] sim/rx: add some missing includes Andrew Burgess
2021-02-01 11:44 ` [PATCH 10/11] sim/rx: avoid pointer arithmetic on void * pointers Andrew Burgess
2021-02-01 11:44 ` [PATCH 11/11] sim/rx: enable build with warnings Andrew Burgess
2021-02-01 14:50 ` Mike Frysinger
2021-02-02 4:53 ` [PATCH] sim: erc32/m32c/rl78: add sim_memory_map stub for gdb Mike Frysinger
2021-02-08 10:57 ` [PATCH 11/11] sim/rx: enable build with warnings Andrew Burgess
2021-02-02 4:37 ` [PATCH 00/11] fix build warnings for rx simulator Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208110100.GE265215@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).