public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <lsix@lancelotsix.com>
To: gdb-patches@sourceware.org
Cc: Lancelot SIX <lsix@lancelotsix.com>
Subject: [PATCH 0/3] Improve the add-inferior completer
Date: Sat, 13 Feb 2021 22:07:49 +0000	[thread overview]
Message-ID: <20210213220752.32581-1-lsix@lancelotsix.com> (raw)

This patch series aims at providing a proper completer for the
add-inferior command based on the gdb::option framework.

The first two commits add support for new option types (zuinteger and
filename) and the third implements the completer.

The filename completer is based on the one already in gdb/completer.c,
but has different behavior when it comes to handling space and quotation
characters in file names.  For the time being, I propose an independent
completer for the gdb::option framework, but if the proposed behavior is
desired for ::file_completer, I’d be happy to merge them.  I am just
unsure whether there are commands that expect to parse file names as
completed by the current completer (I do not think so).

I also have many warnings by dejagnu because test names contain file
names.  This adds quite noise but it seems inevitable given how the test
names are generated. Is this an issue?

All feedback are welcome and will be appreciated.

Lancelot SIX (3):
  gdb::option: Add support for filename option.
  gdb::option: Add support for zuinteger.
  Add completer to the add-inferior command

 gdb/cli/cli-option.c                     | 277 +++++++++++++++++++++++
 gdb/cli/cli-option.h                     |  41 ++++
 gdb/completer.c                          |   3 +
 gdb/completer.h                          |  15 ++
 gdb/inferior.c                           | 123 ++++++----
 gdb/maint-test-options.c                 |  27 ++-
 gdb/testsuite/gdb.base/completion.exp    |  11 +
 gdb/testsuite/gdb.base/options.exp       | 190 +++++++++++++---
 gdb/testsuite/lib/completion-support.exp |   1 -
 9 files changed, 613 insertions(+), 75 deletions(-)

-- 
2.29.2


             reply	other threads:[~2021-02-13 22:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-13 22:07 Lancelot SIX [this message]
2021-02-13 22:07 ` [PATCH 1/3] gdb::option: Add support for filename option Lancelot SIX
2021-02-16 17:45   ` Andrew Burgess
2021-02-16 18:52     ` Lancelot SIX
2021-02-17 10:20       ` Andrew Burgess
2021-02-13 22:07 ` [PATCH 2/3] gdb::option: Add support for zuinteger Lancelot SIX
2021-02-13 22:07 ` [PATCH 3/3] Add completer to the add-inferior command Lancelot SIX
2021-02-16 17:04   ` Andrew Burgess
2021-02-16 18:10     ` Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210213220752.32581-1-lsix@lancelotsix.com \
    --to=lsix@lancelotsix.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).