From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [50.116.126.2]) by sourceware.org (Postfix) with ESMTPS id 5C3A2393D025 for ; Sat, 20 Feb 2021 20:16:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5C3A2393D025 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 09AB4400C8772 for ; Sat, 20 Feb 2021 14:16:21 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id DYfslKz2toE4DDYftlHScj; Sat, 20 Feb 2021 14:16:21 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Qn9P8E+UeNPa/8VgZ5DaZG1/qCh4u/56jOf2rvo7S6s=; b=FTDjOZZO35eS3zAiZoefGE7nZi ScC+vj/yxUQleLcaI9bx2QwuGaJpdnmdjnvtRSzPxXstdZcvPV4kP5hoI+R7MRk7HoxhYX+q71E2m 6RFdCs0oD48/dixmc9cloeXTO; Received: from 97-122-70-152.hlrn.qwest.net ([97.122.70.152]:52678 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lDYfs-000GHL-QI for gdb-patches@sourceware.org; Sat, 20 Feb 2021 13:16:20 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH v3 036/206] Split out eval_op_f_abs Date: Sat, 20 Feb 2021 13:13:19 -0700 Message-Id: <20210220201609.838264-37-tom@tromey.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210220201609.838264-1-tom@tromey.com> References: <20210220201609.838264-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.152 X-Source-L: No X-Exim-ID: 1lDYfs-000GHL-QI X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-152.hlrn.qwest.net (localhost.localdomain) [97.122.70.152]:52678 X-Source-Auth: tom+tromey.com X-Email-Count: 37 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3034.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Feb 2021 20:16:22 -0000 This splits UNOP_ABS into a new function for future use. gdb/ChangeLog 2021-02-20 Tom Tromey * f-lang.c (eval_op_f_abs): New function. (evaluate_subexp_f): Use it. --- gdb/ChangeLog | 5 +++++ gdb/f-lang.c | 50 ++++++++++++++++++++++++++++++-------------------- 2 files changed, 35 insertions(+), 20 deletions(-) diff --git a/gdb/f-lang.c b/gdb/f-lang.c index 08ed56a7469..96ad638348d 100644 --- a/gdb/f-lang.c +++ b/gdb/f-lang.c @@ -799,6 +799,35 @@ fortran_value_subarray (struct value *array, struct expression *exp, return array; } +/* A helper function for UNOP_ABS. */ + +static struct value * +eval_op_f_abs (struct type *expect_type, struct expression *exp, + enum noside noside, + struct value *arg1) +{ + if (noside == EVAL_SKIP) + return eval_skip_value (exp); + struct type *type = value_type (arg1); + switch (type->code ()) + { + case TYPE_CODE_FLT: + { + double d + = fabs (target_float_to_host_double (value_contents (arg1), + value_type (arg1))); + return value_from_host_double (type, d); + } + case TYPE_CODE_INT: + { + LONGEST l = value_as_long (arg1); + l = llabs (l); + return value_from_longest (type, l); + } + } + error (_("ABS of type %s not supported"), TYPE_SAFE_NAME (type)); +} + /* Special expression evaluation cases for Fortran. */ static struct value * @@ -822,26 +851,7 @@ evaluate_subexp_f (struct type *expect_type, struct expression *exp, case UNOP_ABS: arg1 = evaluate_subexp (nullptr, exp, pos, noside); - if (noside == EVAL_SKIP) - return eval_skip_value (exp); - type = value_type (arg1); - switch (type->code ()) - { - case TYPE_CODE_FLT: - { - double d - = fabs (target_float_to_host_double (value_contents (arg1), - value_type (arg1))); - return value_from_host_double (type, d); - } - case TYPE_CODE_INT: - { - LONGEST l = value_as_long (arg1); - l = llabs (l); - return value_from_longest (type, l); - } - } - error (_("ABS of type %s not supported"), TYPE_SAFE_NAME (type)); + return eval_op_f_abs (expect_type, exp, noside, arg1); case BINOP_MOD: arg1 = evaluate_subexp (nullptr, exp, pos, noside); -- 2.26.2