From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/5] Some minor dwz-handling improvements & cleanups
Date: Sat, 20 Feb 2021 20:16:42 -0700 [thread overview]
Message-ID: <20210221031647.949270-1-tom@tromey.com> (raw)
I was looking at adding support for DWARF 5's equivalent to
.gnu_debugaltlink, and found that I could provoke a gdb crash. In
particular, if gdb tries to process a form requiring a "dwz" file, but
no .gnu_debugaltlink section exists, then that will cause a failure.
See patch #3 for some more info on this.
While fixing this, I found a number of small cleanups that made the
result a bit prettier. There are more like this that are possible,
for example basically none of the DWARF code should be in symfile.h.
Let me know what you think.
Tom
next reply other threads:[~2021-02-21 3:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 3:16 Tom Tromey [this message]
2021-02-21 3:16 ` [PATCH 1/5] Create new file dwarf2/sect-names.h Tom Tromey
2021-02-21 3:16 ` [PATCH 2/5] Change section_is_p to a method on dwarf2_section_names Tom Tromey
2021-02-21 3:16 ` [PATCH 3/5] Avoid crash on missing dwz file Tom Tromey
2021-02-21 16:23 ` Tom Tromey
2021-02-21 17:19 ` Tom Tromey
2021-02-21 3:16 ` [PATCH 4/5] Include scoped_fd.h in debuginfod-support.h Tom Tromey
2021-02-21 3:16 ` [PATCH 5/5] Move dwarf2_get_dwz_file to dwarf2/dwz.h Tom Tromey
2021-03-06 16:28 ` [PATCH 0/5] Some minor dwz-handling improvements & cleanups Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210221031647.949270-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).