From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id DED0C385802E for ; Wed, 24 Feb 2021 07:30:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DED0C385802E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8913D11766C; Wed, 24 Feb 2021 02:30:32 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Lvv+XgNyoiTh; Wed, 24 Feb 2021 02:30:32 -0500 (EST) Received: from float.home (localhost.localdomain [127.0.0.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 29CE1117138; Wed, 24 Feb 2021 02:30:32 -0500 (EST) Received: by float.home (Postfix, from userid 1000) id 3C97CA7037; Wed, 24 Feb 2021 11:30:27 +0400 (+04) Date: Wed, 24 Feb 2021 11:30:27 +0400 From: Joel Brobecker To: Simon Marchi Cc: Simon Marchi via Gdb-patches , Tom Tromey , nilsgladitz@gmail.com Subject: Re: [PATCH 3/4] gdb/dwarf: don't enqueue CU in maybe_queue_comp_unit if already expanded Message-ID: <20210224073027.GF3485@adacore.com> References: <20201117191231.2712629-1-simon.marchi@polymtl.ca> <20201117191231.2712629-4-simon.marchi@polymtl.ca> <87eejyr7uq.fsf@tromey.com> <59300a21-12f4-1e6b-b635-c57f82f85ea4@polymtl.ca> <4c684d09-4e81-becf-d3be-3ba6105f7d59@polymtl.ca> <20210223065302.GA370419@adacore.com> <300663eb-c81b-65bb-f2a4-b650bda2d89e@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2021 07:30:34 -0000 > >> It's been two months since the patch has been waiting for feedback, > >> with a ping a month ago. At this point, I think we should just trust > >> your judgement on this one, and go ahead, especially if the person > >> who reported the issue confirm his issue was fixed. > >> > >> WDYT? > > > > Ok, I'll push them to master, and push them to gdb-10-branch after doing a bit of testing. > > > > Simon > > Ok, this is now pushed to both branches. Awesome. Thanks Simon. -- Joel