[PATCH 18/22] Update the source location with Frame.select

[Hannes Domani <ssbssa@yahoo.de>]

If the optional argument is True, then the current source location is
also updated, the same as if 'frame #' were used.
With this, a following 'list' call will show the source location of the
current frame instead of the previous one, and the TUI source window is
also updated.

PR python/24534
---
 gdb/python/py-frame.c | 29 ++++++++++++++++++++++++++++-
 gdb/tui/tui-hooks.c   |  8 ++++++++
 gdb/tui/tui-hooks.h   |  2 ++
 3 files changed, 38 insertions(+), 1 deletion(-)

diff --git a/gdb/python/py-frame.c b/gdb/python/py-frame.c
index 8e32ba55de4..ef4eae1d745 100644
--- a/gdb/python/py-frame.c
+++ b/gdb/python/py-frame.c
@@ -28,6 +28,11 @@
 #include "symfile.h"
 #include "objfiles.h"
 
+#ifdef TUI
+#include "tui/tui.h"
+#include "tui/tui-hooks.h"
+#endif
+
 struct frame_object {
   PyObject_HEAD
   struct frame_id frame_id;
@@ -564,12 +569,34 @@ static PyObject *
 frapy_select (PyObject *self, PyObject *args)
 {
   struct frame_info *fi;
+  PyObject *update_sal_obj = NULL;
+
+  if (!PyArg_ParseTuple (args, "|O!", &PyBool_Type, &update_sal_obj))
+    return NULL;
+
+  int update_sal = 0;
+  if (update_sal_obj)
+    {
+      update_sal = PyObject_IsTrue (update_sal_obj);
+      if (update_sal < 0)
+	return NULL;
+    }
 
   try
     {
       FRAPY_REQUIRE_VALID (self, fi);
 
       select_frame (fi);
+
+      if (update_sal)
+	{
+	  set_current_sal_from_frame (fi);
+
+#ifdef TUI
+	  if (tui_active)
+	    tui_frame_changed ();
+#endif
+	}
     }
   catch (const gdb_exception &except)
     {
@@ -748,7 +775,7 @@ Return the frame's symtab and line." },
   { "read_var", frapy_read_var, METH_VARARGS,
     "read_var (variable) -> gdb.Value.\n\
 Return the value of the variable in this frame." },
-  { "select", frapy_select, METH_NOARGS,
+  { "select", frapy_select, METH_VARARGS,
     "Select this frame as the user's current frame." },
   {NULL}  /* Sentinel */
 };
diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c
index 2d7660acade..fa8f63e1146 100644
--- a/gdb/tui/tui-hooks.c
+++ b/gdb/tui/tui-hooks.c
@@ -187,6 +187,14 @@ tui_before_prompt (const char *current_gdb_prompt)
   from_source_symtab = false;
 }
 
+void
+tui_frame_changed (void)
+{
+  from_stack = true;
+  tui_refresh_frame_and_register_information ();
+  from_stack = false;
+}
+
 /* Observer for the normal_stop notification.  */
 
 static void
diff --git a/gdb/tui/tui-hooks.h b/gdb/tui/tui-hooks.h
index 11f8ef3d0d1..2ed2021cea6 100644
--- a/gdb/tui/tui-hooks.h
+++ b/gdb/tui/tui-hooks.h
@@ -20,6 +20,8 @@
 #ifndef TUI_TUI_HOOKS_H
 #define TUI_TUI_HOOKS_H
 
+extern void tui_frame_changed (void);
+
 extern void tui_install_hooks (void);
 extern void tui_remove_hooks (void);
 
-- 
2.30.1