From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3kWJPYAoKC5w87EAOEJCANCKKCHA.8KIC97-L6P8DAOOKQN8AS6NA.KNC@flex--cbiesinger.bounces.google.com> Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by sourceware.org (Postfix) with ESMTPS id 98FFE3857C7E for ; Mon, 15 Mar 2021 13:35:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 98FFE3857C7E Received: by mail-yb1-xb49.google.com with SMTP id f81so37964578yba.8 for ; Mon, 15 Mar 2021 06:35:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=395ldS82M0ikpSHUQht0m3IsPrOqADvkpFx9nxbdcho=; b=UBNANNztp5l1r/HVc0Mqn5OJn9Ea9jy2RBDokPQYjgoSdC3+lXF0kXtTHu5V3YXBC+ g1yQ0EACe+CsNzdBcFnd4ENyuu+RZv0W6kY27qDgZ21ey47gXSPDWXgJq9P8I3bzcad+ iVoPSdO0Kv1nRkrikO1RPhvJnS9pmyYk6CtnUjFzvY/xm5s8/qcMg9wB7ZYKWGBlVLRZ YQS8Kc8jQN/VRwMu1YDV0lfqvczipkeuLuJRr38hPdzrAS9hzh0f7+VGu588eJ5iKAou EqdIl5xd7lE3J2H0F2sbSBWfhB2QO9JUSWBIRrsPYPnWq48jeZDx2wz6BqVfoDQnF+dw GVwA== X-Gm-Message-State: AOAM531JMXQZjYoeQ6TEgp2zdogolWHYLOLfb/z1FzmovX1ibKkUBOVP 0JldJX2U1aoZrSFaov9m1vVEQy489vCmbPp5hpaNkKozTWFRoL2vNOzgfBjesw8rsavKge6DLdt HCx2Ztuxdc84a74eRREvqg6YP6D1SDzSn2Fxg7ax+jqPNyCj55RPzlvSdVyXMXYxJDD2BILOgQI 8+cg== X-Google-Smtp-Source: ABdhPJyyyZ7JLqr3HT4vc/f/Z6moWCHJcE70qaVbGhtGxX8ItERBSgeCeRyiBBR77NWasu3eyT/obyQ1emzZPuqF X-Received: from cbiesinger2.msn.corp.google.com ([2620:15c:1:200:cc79:1c41:32bf:d94d]) (user=cbiesinger job=sendgmr) by 2002:a25:dfcc:: with SMTP id w195mr36854835ybg.210.1615815313036; Mon, 15 Mar 2021 06:35:13 -0700 (PDT) Date: Mon, 15 Mar 2021 08:35:10 -0500 Message-Id: <20210315133510.607693-1-cbiesinger@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog Subject: [PATCH] Fix cygwin build error From: Christian Biesinger To: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-18.9 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 13:35:14 -0000 With "gcc version 10.2.0 (GCC)" on cygwin, I get this build error: CXX windows-nat.o In file included from ../../gdb/../gdbsupport/common-defs.h:129, from ../../gdb/defs.h:28, from ../../gdb/windows-nat.c:24: ../../gdb/windows-nat.c: In function =E2=80=98void windows_init_thread_list= ()=E2=80=99: ../../gdb/windows-nat.c:513:17: error: zero-length gnu_printf format string= [-Werror=3Dformat-zero-length] 513 | DEBUG_EVENTS (""); | ^~ ../../gdb/../gdbsupport/common-debug.h:65:43: note: in definition of macro = =E2=80=98debug_prefixed_printf_cond=E2=80=99 65 | debug_prefixed_printf (module, __func__, fmt, ##__VA_ARGS__); \ | ^~~ ../../gdb/windows-nat.c:513:3: note: in expansion of macro =E2=80=98DEBUG_E= VENTS=E2=80=99 513 | DEBUG_EVENTS (""); | ^~~~~~~~~~~~ cc1plus: all warnings being treated as errors This was introduced in 4ef367bffd73d50002339deba40983530ccb9d15, which remo= ved the function name from this debug message: - DEBUG_EVENTS (("gdb: windows_init_thread_list\n")); + DEBUG_EVENTS (""); This patch just restores the function name. This will probably be easier to understand as well. gdb/ChangeLog: 2021-03-15 Christian Biesinger * windows-nat.c (windows_init_thread_list): Add function name to debug log. --- gdb/windows-nat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 8f6fb3ddcdf..269c41a3097 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -510,7 +510,7 @@ windows_add_thread (ptid_t ptid, HANDLE h, void *tlb, b= ool main_thread_p) static void windows_init_thread_list (void) { - DEBUG_EVENTS (""); + DEBUG_EVENTS ("windows_init_thread_list"); init_thread_list (); =20 for (windows_thread_info *here : thread_list) --=20 2.31.0.rc2.261.g7f71774620-goog