From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 24A323858C27 for ; Tue, 16 Mar 2021 03:45:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 24A323858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 927C2117F88; Mon, 15 Mar 2021 23:45:57 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xsS9uW9HGUH9; Mon, 15 Mar 2021 23:45:57 -0400 (EDT) Received: from float.home (localhost.localdomain [127.0.0.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 22FE5117F6F; Mon, 15 Mar 2021 23:45:57 -0400 (EDT) Received: by float.home (Postfix, from userid 1000) id A1FA5A1241; Tue, 16 Mar 2021 07:45:51 +0400 (+04) Date: Tue, 16 Mar 2021 07:45:51 +0400 From: Joel Brobecker To: Simon Marchi Cc: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org Subject: Re: GDB 10.2 Release: Proposing Mar 13-14 for official GDB 10.2 release Message-ID: <20210316034551.GE3188@adacore.com> References: <20210306064611.GB807147@adacore.com> <06d96113-d09b-993f-0f55-00c297b4e591@simark.ca> <20210310024850.GA247585@adacore.com> <17184b08-d7e7-a62c-b689-35ab3f179f06@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17184b08-d7e7-a62c-b689-35ab3f179f06@polymtl.ca> X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 03:45:59 -0000 Hi Simon, > >> Tom Tromey and I would be good candidates to look a it, > >> because it's related to the DWARF symbol sharing, which > >> we've both worked on. I will try to give it a look in > >> the following days. > > > > Thanks for the heads up, Simon. I've changed its Target Mileston > > to 10.2 in Bugzilla. > > > > I've been looking at this on and off for the last few days, and I don't > think I'll be able to come up with a proper fix in a short time frame. > And even if I did, I think it would be too risky for merging in a stable > branch right before releasing. That's what I was fearing already, when I saw the PR and the discussions that were logged so far. > The alternative I see to unblock the release is to disable the sharing of > partial symbols between objfiles for now. Essentially, a patch that does > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index 704ba9f36655..5d9256bece1e 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -1954,7 +1954,8 @@ dwarf2_has_info (struct objfile *objfile, > doesn't require relocations and if there aren't partial symbols > from some other reader. */ > if (!objfile_has_partial_symbols (objfile) > - && !gdb_bfd_requires_relocations (objfile->obfd)) > + && !gdb_bfd_requires_relocations (objfile->obfd) > + && 0) > { > /* See if one has been created for this BFD yet. */ > per_bfd = dwarf2_per_bfd_bfd_data_key.get (objfile->obfd); > > We can then take our time to look at a proper fix for master. It's quite nice to see that this feature could be disabled with a one-liner like this. Unless Tom has other ideas, this seems like the way to go for me. I also wanted to mention that, in terms of timing, I was planning on starting the regular updates for the 11.1 releases pretty much right after the GDB 10.2 is out. We will just have to list this one right from the beginning. Procedurally speaking, what would help is if we close the PR about the crash with the target milestone set to 10.2 right after your patch is in, and then re-open the PR about the partial symtab sharing to fix the crash on master (or open a new one if there wasn't one already). That way, anyone asking for the list of fixes from 10.1 to 10.2 would find this issue (this is something I do when publishing a .2, for instance). Thanks Simon! -- Joel