From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by sourceware.org (Postfix) with ESMTPS id DD4CC385E83A for ; Mon, 22 Mar 2021 13:21:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DD4CC385E83A Received: by mail-qt1-x835.google.com with SMTP id h7so12223745qtx.3 for ; Mon, 22 Mar 2021 06:21:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f3op0ewh8A9n8l5YI0cYaayEU/TDXSqXFCrAz+nO6uo=; b=O+Bc6o8v+abEAHw1ofjITmiCefcCLgKQySgfH8dtIFu0pUlZRnol9NO1d0LV/xEqKb oTP1zPHj/TLrCNJHf5bbtbQKulLGLXlBixsK5nWr4Prd7wRlSyM2lhlZOZNXY/WEqgbp CjSuA0Xohm8SOIpryhB/M/fYL+anl84J2KnhRkO5LXTRa4Z4ucrrrQGGx9bQRjDEESTe 9iBEWMSOUYDqz0M/G/LHzxOkaHgLXHIF0cS4sg6lJIHLHs6bUExwxZVzoQ/yLwl9uByu iRKIRLM92k1Y9Qu7au+fWkvhxz4zFBke4qxYEvxEH5EVXlrS0eCJ1aFoIBW2ef7P8yJp vBGg== X-Gm-Message-State: AOAM531SnphzAIJmMWxOq2Hd5i6DiUNX7bgKch0BWQ2hcv47EBwiNAJ0 KZ3vxaGJfLfiq0ldLhf1wufpAUpYSCkAZA== X-Google-Smtp-Source: ABdhPJxQuEaKqWSQE9h78jT/KYsl7x3Z31bU14TYXichXa4dmxaNLcs9xVeEcU1R0nobeu28NNcCsg== X-Received: by 2002:ac8:5313:: with SMTP id t19mr9506760qtn.148.1616419317508; Mon, 22 Mar 2021 06:21:57 -0700 (PDT) Received: from localhost.localdomain ([2804:7f0:4841:2841:2c21:ec8a:30f3:55a6]) by smtp.gmail.com with ESMTPSA id r35sm7364575qtd.95.2021.03.22.06.21.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 06:21:57 -0700 (PDT) From: Luis Machado To: gdb-patches@sourceware.org Subject: [PATCH v6 16/25] AArch64: Add unit testing for logical tag set/get operations Date: Mon, 22 Mar 2021 10:21:10 -0300 Message-Id: <20210322132120.1202230-17-luis.machado@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210322132120.1202230-1-luis.machado@linaro.org> References: <20210322132120.1202230-1-luis.machado@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2021 13:21:59 -0000 Update on v4: - Adjust function names. -- Add some unit testing to exercise setting/getting logical tags in the AArch64 implementation. gdb/ChangeLog: YYYY-MM-DD Luis Machado * aarch64-linux-tdep.c: Include gdbsupport/selftest.h. (aarch64_linux_ltag_tests): New function. (_initialize_aarch64_linux_tdep): Register aarch64_linux_ltag_tests. --- gdb/aarch64-linux-tdep.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c index 29440a8510c..9434f90e8f6 100644 --- a/gdb/aarch64-linux-tdep.c +++ b/gdb/aarch64-linux-tdep.c @@ -51,6 +51,8 @@ #include "arch-utils.h" #include "value.h" +#include "gdbsupport/selftest.h" + /* Signal frame handling. +------------+ ^ @@ -1942,10 +1944,39 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) set_gdbarch_gcc_target_options (gdbarch, aarch64_linux_gcc_target_options); } +#if GDB_SELF_TEST + +namespace selftests { + +/* Verify functions to read and write logical tags. */ + +static void +aarch64_linux_ltag_tests (void) +{ + /* We have 4 bits of tags, but we test writing all the bits of the top + byte of address. */ + for (int i = 0; i < 1 << 8; i++) + { + CORE_ADDR addr = ((CORE_ADDR) i << 56) | 0xdeadbeef; + SELF_CHECK (aarch64_mte_get_ltag (addr) == (i & 0xf)); + + addr = aarch64_mte_set_ltag (0xdeadbeef, i); + SELF_CHECK (addr = ((CORE_ADDR) (i & 0xf) << 56) | 0xdeadbeef); + } +} + +} // namespace selftests +#endif /* GDB_SELF_TEST */ + void _initialize_aarch64_linux_tdep (); void _initialize_aarch64_linux_tdep () { gdbarch_register_osabi (bfd_arch_aarch64, 0, GDB_OSABI_LINUX, aarch64_linux_init_abi); + +#if GDB_SELF_TEST + selftests::register_test ("aarch64-linux-tagged-address", + selftests::aarch64_linux_ltag_tests); +#endif } -- 2.25.1