From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 155DD38515E3 for ; Thu, 25 Mar 2021 11:11:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 155DD38515E3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-ej1-x62d.google.com with SMTP id a7so2240304ejs.3 for ; Thu, 25 Mar 2021 04:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F8U4uB2q/qKFYetqrDtOVe/lA2KoDsnoF16DDV7d3R8=; b=MiwP9bPgVDFnSxpKD9anKJVSkA3ppJxM8bEgwoEAbo7pGSrCD5sp6AOm4WWJ8eTsjO o4issoYqRqHiY2gWYXldmI7/XlCVEGBy9Bxh+OuvsrcEOq/0ndUMZ6OnYh/a9RkSvZrv vS1DI6RXHAKWxvsBrdFCI5VKg3L2hQN7k5DIZiVlsPJsfEvAi66PtjbMEekLu2Itdy+v 8gkLgjckd4P6KuQp1anYUbvBLY5QzJkeu5HdyFwSaI33Yk3kATK/Na80SsOjuH/QEHGy vYTjHkrn29tRQugL+Xs15r/XFJt2oVEO9gbYcyLWb6E5KWLx4Dog7iAkxf3K5AnBVJeh 78rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F8U4uB2q/qKFYetqrDtOVe/lA2KoDsnoF16DDV7d3R8=; b=OBiVopRQlggX+zWrmxVqGrBQHFQ7pVBuSfgaYRoaSCXxN+mtPfbWgmXZ17TVMWpNw6 d3XnL06odXaauFO7EbD6V8wl8Z1wer3JHklJVpNrV2ItDERI5tHCjK7j6sUGd2fqiXP1 NGGTgklE1viVHvHbnKPntN7Lim8/iQLXWtklXAx+KTyodd1zSZQzyH7XdDuYcJxx23gO Y1k9SUl9gxEza9dYWOI7rcBUSCzaQn2o44EihGMrZ9We4i9KVrCe1FJuHeiUL2Pr4TkY 7vsP1jPixPowGISCoVF5LmNg+5QO/E1OAxwwuOD2tqR2ESioayOhseFS/auJNBLDQUtw 24QQ== X-Gm-Message-State: AOAM531sOLcCIGY+pL3x4Y91xETcaB5PUcrMIm3+rssSIhOSOx3YDArA Ih0Lh7yXxAL42KPb+Fj8Xy4+ow== X-Google-Smtp-Source: ABdhPJzI+jx/xOdu2ywK694YYI4ablsq4yMsi5SwdbcArJnZeEgGIWTXO/9M8nccpLYQolWO6pv7vw== X-Received: by 2002:a17:906:2dda:: with SMTP id h26mr8778055eji.163.1616670660140; Thu, 25 Mar 2021 04:11:00 -0700 (PDT) Received: from localhost (host165-120-118-227.range165-120.btcentralplus.com. [165.120.118.227]) by smtp.gmail.com with ESMTPSA id hd37sm2192736ejc.114.2021.03.25.04.10.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 04:10:59 -0700 (PDT) Date: Thu, 25 Mar 2021 11:10:58 +0000 From: Andrew Burgess To: Changbin Du Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb/riscv: fix creating breakpoints at invalid addresses Message-ID: <20210325111058.GP5520@embecosm.com> References: <20210325093954.3210-1-changbin.du@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325093954.3210-1-changbin.du@gmail.com> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 11:10:30 up 13 days, 18:21, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2021 11:11:02 -0000 * Changbin Du via Gdb-patches [2021-03-25 09:39:54 +0000]: > To allow breakpoints to be created at invalid addresses, > target_read_code() is used instead of read_code(). The > original read_code() should be removed, otherwise the > breakpoint command will fail. > > (gdb) hbreak setup_arch > Cannot access memory at address 0xffffffe000c036ac > > gdb/ChangeLog: > 2021-03-24 Changbin Du > > * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Remove call to read_code. Thanks. I pushed this fix to master. Andrew > --- > gdb/ChangeLog | 4 ++++ > gdb/riscv-tdep.c | 1 - > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index a548c58e8f72..a84299a2cc38 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,7 @@ > +2021-03-25 Changbin Du > + > + * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Remove call to read_code. > + > 2021-03-24 Simon Marchi > > * target.h (current_top_target): Remove, make callers use the > diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c > index ca3efaf71cf8..c17839968465 100644 > --- a/gdb/riscv-tdep.c > +++ b/gdb/riscv-tdep.c > @@ -706,7 +706,6 @@ riscv_breakpoint_kind_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pcptr) > user. */ > if (target_read_code (*pcptr, buf, 1) == -1) > buf[0] = 0; > - read_code (*pcptr, buf, 1); > } > > if (riscv_debug_breakpoints) > -- > 2.27.0 > >